Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: implement business selector using new selector component #6525

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 26, 2024

What type of PR is this?

/kind improvement
/area ui
/milestone 2.19.x

What this PR does / why we need it:

使用 #6473 中重构的 Formkit Select 组件来实现用户、文章、页面等各种业务搜索组件。

Fixes #4931

How to test it?

测试各类搜索组件是否正常可用。
测试从旧版本升级后,原有数据是否可以正常显示。

Does this PR introduce a user-facing change?

使用重构的 Formkit Select 组件来实现业务选择器。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove August 26, 2024 10:38
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.79%. Comparing base (6cd8dc8) to head (2cc254a).
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6525      +/-   ##
============================================
- Coverage     58.18%   57.79%   -0.39%     
- Complexity     3774     3860      +86     
============================================
  Files           651      668      +17     
  Lines         22125    22829     +704     
  Branches       1538     1584      +46     
============================================
+ Hits          12873    13195     +322     
- Misses         8641     9014     +373     
- Partials        611      620       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG force-pushed the pref/use-refactor-select branch from f109d0b to 2cc254a Compare August 27, 2024 07:08
Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @halo-dev/sig-halo-console

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
Copy link

f2c-ci-robot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2815678 into halo-dev:main Aug 27, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 27, 2024
@LIlGG LIlGG deleted the pref/use-refactor-select branch August 28, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Schema 增加 userSelect 和 userCheckbox 组件
3 participants