Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unified parameter list method for post finder #6531

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 27, 2024

What type of PR is this?

/kind feature
/milestone 2.19.x
/area core

What this PR does / why we need it:

为 postFinder 添加一个统一参数的 list 方法并支持传递排序参数

Fixes #4933

Does this PR introduce a user-facing change?

为 postFinder 添加一个统一参数的 list 方法并支持传递排序参数

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby August 27, 2024 05:13
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 27, 2024
@guqing guqing mentioned this pull request Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 62.26415% with 20 lines in your changes missing coverage. Please review.

Project coverage is 57.84%. Comparing base (6cd8dc8) to head (db2100b).
Report is 27 commits behind head on main.

Files Patch % Lines
...un/halo/app/theme/finders/impl/PostFinderImpl.java 51.28% 16 Missing and 3 partials ⚠️
.../main/java/run/halo/app/infra/utils/SortUtils.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6531      +/-   ##
============================================
- Coverage     58.18%   57.84%   -0.34%     
- Complexity     3774     3874     +100     
============================================
  Files           651      669      +18     
  Lines         22125    22893     +768     
  Branches       1538     1593      +55     
============================================
+ Hits          12873    13243     +370     
- Misses         8641     9025     +384     
- Partials        611      625      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 27, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

需要完善一下 halo-dev/docs 的文档。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@guqing guqing requested a review from JohnNiang August 27, 2024 09:55
Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
Copy link

f2c-ci-robot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ac0700e into halo-dev:main Aug 27, 2024
8 checks passed
@guqing guqing deleted the refactor/post-finder branch August 27, 2024 10:17
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 27, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Aug 29, 2024
#### What type of PR is this?
/kind bug
/area core
/milestone 2.19.x

#### What this PR does / why we need it:
修复 postFinder 的 list 排序参数不生效的问题

此问题由于 #6531 导致

#### Which issue(s) this PR fixes:
Fixes #6534

#### Does this PR introduce a user-facing change?
```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Sep 5, 2024
### What this PR does?

为 halo-dev/halo#6531 补充文档说明


```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望文章 Finder API 能够支持访问量排序
3 participants