-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unified parameter list method for post finder #6531
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6531 +/- ##
============================================
- Coverage 58.18% 57.84% -0.34%
- Complexity 3774 3874 +100
============================================
Files 651 669 +18
Lines 22125 22893 +768
Branches 1538 1593 +55
============================================
+ Hits 12873 13243 +370
- Misses 8641 9025 +384
- Partials 611 625 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
需要完善一下 halo-dev/docs 的文档。
application/src/main/java/run/halo/app/theme/finders/impl/PostFinderImpl.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
### What this PR does? 为 halo-dev/halo#6531 补充文档说明 ```release-note None ```
What type of PR is this?
/kind feature
/milestone 2.19.x
/area core
What this PR does / why we need it:
为 postFinder 添加一个统一参数的 list 方法并支持传递排序参数
Fixes #4933
Does this PR introduce a user-facing change?