Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post list sorting parameter not working #6544

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 29, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.19.x

What this PR does / why we need it:

修复 postFinder 的 list 排序参数不生效的问题

此问题由于 #6531 导致

Which issue(s) this PR fixes:

Fixes #6534

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen August 29, 2024 02:27
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.80%. Comparing base (6cd8dc8) to head (d8b5bac).
Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6544      +/-   ##
============================================
- Coverage     58.18%   57.80%   -0.39%     
- Complexity     3774     3872      +98     
============================================
  Files           651      669      +18     
  Lines         22125    22889     +764     
  Branches       1538     1593      +55     
============================================
+ Hits          12873    13230     +357     
- Misses         8641     9034     +393     
- Partials        611      625      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the fix/sort-for-post branch from 7b2958f to d8b5bac Compare August 29, 2024 02:35
Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link

f2c-ci-robot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 0a13981 into halo-dev:main Aug 29, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Sep 1, 2024
@guqing guqing deleted the fix/sort-for-post branch September 5, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.19.0-rc.2版本 postFinder.list 方法排序无效
3 participants