-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symlink support, closes #8 #12
Conversation
1 similar comment
I’ll have to look at this a bit more in depth—and I haven’t had a chance to do this so far, but the immediately problem that I’m seeing is that one of these is Unicode ( |
@halostatue I've had problems like that before where Ruby's ideas of default string encoding is ... in disagreement with my assumptions. Things maybe to check:
Hope this helps! I've had many encoding battles with Ruby in the past :P |
@halostatue would love to see symlinks supported, any chance of this being worked on? |
@lollipopman I have no time to do so. The PR is essentially complete, except for the unit test failure, so you could start from there. |
@fetep @lollipopman I think that I have this fixed properly in #42 against the current codebase. If you could test this, we can release it as part of 0.10 or shortly after as 0.11. |
@halostatue awesome, I'll give it a try, thanks! |
@lollipopman Did you get a chance to test #12? |
@halostatue, I tested it today, seems to work perfect, thanks again! |
This creates tar archives with working symlinks, although I am having trouble making the test for this work. I end up with this as a failure, any pointers/help appreciated:
This change is