Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Block Requests option #913

Closed
ul16 opened this issue Dec 27, 2024 · 5 comments · Fixed by #914
Closed

Max Block Requests option #913

ul16 opened this issue Dec 27, 2024 · 5 comments · Fixed by #914

Comments

@ul16
Copy link

ul16 commented Dec 27, 2024

Whenever it reaches a height of 160,000 it will not accept a set of blocks from any peer for some odd reason. It keeps saying "peer advertised too many blocks" And I looked into it, and there's no option to increase this max block request limit for a given peer connection. I have attached an image about what i'm talking about.
Screenshot_20241226_210346_Termux

@nodech
Copy link
Contributor

nodech commented Dec 27, 2024

The limits are there for DOS and otherwise sanity limits. There's no reason for removing those limits, on the other hand nodes should NOT be sending over that limit. (Note: this is number of headers, not the actual blocks)

What is your node version and what's the version of the peer (or ip if it's public) that is sending those blocks?

It looks like you are using v6.x (Should work fine), but surprising that it starts complaining after 160k (which is checkpoint for v6)

@nodech
Copy link
Contributor

nodech commented Dec 27, 2024

Okay, I think I found the issue. Currently you can use --checkpoints=false - (makes it slower to sync, but will sync) and you can re-enable the checkpoints again at 165k block. (5k blocks) 175k block. I will add in-between checkpoint at 200k blocks

@nodech
Copy link
Contributor

nodech commented Dec 27, 2024

Thanks for the details, that was the main clue for the issue !

I will be releasing v7.0.1 with the fix. Alternatively, you can disable checkpoints as mentioned above and in the PR.

@ul16
Copy link
Author

ul16 commented Dec 27, 2024 via email

@nodech
Copy link
Contributor

nodech commented Dec 27, 2024

They all are XD it kept connecting to multiple different nodes to get

@ul16

It should be fixed now! You can upgrade to the latest version. (or disable checkpoints till 175k block)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants