Add checkpoint between 160k and 225k #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falci
approved these changes
Dec 27, 2024
nodech
force-pushed
the
add-mid-checkpoint
branch
from
39fc6cc to
f484c63
Compare
nodech
added a commit
that referenced
this pull request
Dec 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way headers are requested for checkpoints is slightly different than normal - it does header requests in bulk between two checkpoints. Because the difference between 220k and 160k is 65k - it becomes bigger than general limit to the number of headers that can be requested: 51k.
This should resolve issue, as the gaps between them will become lower than 51k now.
Temporary solution for those who don't want to upgrade is to disable checkpoints until node reaches 175k blocks. (After 160k) Or upgrade to the release version with this PR.
Closes: #913
Closes: #909 (Even though it was resolved, probably the node got those 15k blocks eventually and slowly?)