forked from dotnet/wpf
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE0017 #58
Open
harshit7962
wants to merge
38
commits into
main
Choose a base branch
from
editorconfigCleanup11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
IDE0017 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…217.2 (dotnet#10195) [main] Update dependencies from dotnet/arcade
…217.2 (dotnet#10193) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24616.1 -> To Version 10.0.0-beta.24617.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20241220.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24617.2 -> To Version 10.0.0-beta.24620.3 * Update dependencies from https://github.com/dotnet/arcade build 20241222.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24617.2 -> To Version 10.0.0-beta.24622.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/winforms build 20241220.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24620.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24611.1 -> To Version 10.0.0-alpha.1.24619.8 (parent: Microsoft.Private.Winforms * Update dependencies from https://github.com/dotnet/winforms build 20241220.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24620.2 * Update dependencies from https://github.com/dotnet/winforms build 20241220.3 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24620.3 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24611.1 -> To Version 10.0.0-alpha.1.24620.10 (parent: Microsoft.Private.Winforms * Update dependencies from https://github.com/dotnet/winforms build 20241222.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24622.2 * Update dependencies from https://github.com/dotnet/winforms build 20241223.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24623.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24611.1 -> To Version 10.0.0-alpha.1.24622.1 (parent: Microsoft.Private.Winforms * Update dependencies from https://github.com/dotnet/winforms build 20241223.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24623.2 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24611.1 -> To Version 10.0.0-alpha.1.24623.2 (parent: Microsoft.Private.Winforms * Update dependencies from https://github.com/dotnet/winforms build 20241226.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24617.1 -> To Version 10.0.0-alpha.1.24626.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24611.1 -> To Version 10.0.0-alpha.1.24625.1 (parent: Microsoft.Private.Winforms --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…222.1 (dotnet#10201) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24617.2 -> To Version 10.0.0-beta.24622.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…223.1 (dotnet#10202) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24622.1 -> To Version 10.0.0-beta.24623.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…226.1 (dotnet#10207) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24623.1 -> To Version 10.0.0-beta.24626.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/winforms build 20241226.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24626.1 -> To Version 10.0.0-alpha.1.24626.2 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24625.1 -> To Version 10.0.0-alpha.1.24626.2 (parent: Microsoft.Private.Winforms * Update dependencies from https://github.com/dotnet/winforms build 20241227.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24626.1 -> To Version 10.0.0-alpha.1.24627.1 * Update dependencies from https://github.com/dotnet/winforms build 20241228.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24626.1 -> To Version 10.0.0-alpha.1.24628.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24625.1 -> To Version 10.0.0-alpha.1.24628.1 (parent: Microsoft.Private.Winforms --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…226.1 (dotnet#10210) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.24623.1 -> To Version 10.0.0-beta.24626.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update: Resolve SA1206 in src * Update: Resolve SA1513 in src * Update: Resolve SA1518 in src * Update: Resolve SA1508 in src * Update: Resolve SA1507 in src * Update: Resolve SA1505 in src * Update: Resolve SA1500 in src
* Add System.Xaml tests * Fix IDE warnings and fix Debug assert tests
…otnet#9697) * Simplify CanConvertFrom * Simplify CanConvertTo * Speed up and simplify ConvertFrom, add fast-path for F-keys * Speed up and simplify ConvertTo, add IsDefinedKey helper * Add documentation, formatting adjustments only * Use IsDefinedKey in CanConvertTo as well * Remove redundant usings * Fix an unlikely IndexOutOfRangeException we could have introduced * Prevent behaviour change, let it throw an exception * Address PR feedback * Address nits, fix spelling
Automated changes. Contributes to dotnet#10018
Manual changes. Contributes to dotnet#10018
…th generic List (dotnet#9853) * Replace ArrayList/ICollection with List<NotifyCollectionChangedEventArgs> * Rename EmptyArrayList -> s_emptyList * Values inside changeLog can never be NULL and we no longer need to cast * _changeLog can never be NULL, re-init is under same lock
…41229.1 (dotnet#10214) Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24628.1 -> To Version 10.0.0-alpha.1.24629.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24628.1 -> To Version 10.0.0-alpha.1.24629.1 (parent: Microsoft.Private.Winforms Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…tnet#9943) * Rmove OleCmdHelper/CommandWithArgument classes (XBAP) * Remove obsolete enums from IBrowserHostServices * Remove ISecureCommand / SecureUICommand dead code
dotnet#9603) * replace _nameToGroupMap Hashtable with Dictionary<object, WeakReference> * address PR feedback * Remove namespace declaration (PR feedback)
* Update dependencies from https://github.com/dotnet/winforms build 20241230.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24629.1 -> To Version 10.0.0-alpha.1.24630.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24629.1 -> To Version 10.0.0-alpha.1.24630.4 (parent: Microsoft.Private.Winforms * Update dependencies from https://github.com/dotnet/winforms build 20241231.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24629.1 -> To Version 10.0.0-alpha.1.24631.1 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.10.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.Formats.Nrbf,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 10.0.0-alpha.1.24629.1 -> To Version 10.0.0-alpha.1.24631.2 (parent: Microsoft.Private.Winforms --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Resolve the following SA Ids: 1129, 1121, 1028, 1027, 1014, 1005, 1001
…dotnet#9432) * replace ArrayList in ItemContainerGenerator with List<EmptyGroupItem> * use fully qualified type when initializing a new instance
…-arguments-in-WindowsBase [Cleanup] Use named arguments in WindowsBase
…ations (dotnet#9683) * Optimize performance of ConvertTo function, remove allocs * Perf of ConvertFrom 3x, reduce allocs to zero * Simplify CanConvertFrom * Simplify CanConvertTo * ModifierKeysFlag is now a compile-time constant instead of a static field * Remove redundant usings * Add documentation/formatting changes only * Add allocation-free fast-path for single modifier scenario
…finish cleanup (dotnet#9865) * Remove IBrowserCallbackServices XBAP-related dead code * Remove code paths called via ApplicationProxyInternal * Keep IsViewer to better show intent (MimeType was never set on .NET Core) * Explain why IsInitialViewerNavigation is always false * Remove IsInitialViewerNavigation from conditions where the value does not matter * Remove some remarks to RootBrowserWindow that no longer exists * Remove IInternetSecurityMgrSite as it is no longer used without XBAP support * Final cleanup in AppSecurityManager * Cleanup after dotnet#9855 merge * Add back a forgotten using for UnsafeNativeMethods
…102.1 (dotnet#10219) [main] Update dependencies from dotnet/arcade
…ringToken (dotnet#9508) * remove array allocation with CollectionsMarshal * use foreach to prevent multiple pointer shifts * naive span-based unescape over MatchEvaluator, increase perf by 6 times, decrease allocs by 8 times * improve func name and comments, use BamlConst.EscapeChar * add initial searchvalues<string> for tokens to match performance for string with no escapes * Fix is-pattern in null checks, comment spaces
…103.3 (dotnet#10222) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 10.0.0-beta.25052.1 -> To Version 10.0.0-beta.25053.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/winforms build 20250103.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24631.1 -> To Version 10.0.0-alpha.1.25053.1 * Update dependencies from https://github.com/dotnet/winforms build 20250104.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 10.0.0-alpha.1.24631.1 -> To Version 10.0.0-alpha.1.25054.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fix IDE warnings: - IDE0019: Use pattern matching to avoid as followed by a null check - IDE0020: Use pattern matching to avoid is check followed by a cast (with variable) - IDE0029: Use coalesce expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Main PR
Description
Customer Impact
Regression
Testing
Risk