Check to parameter in eth_call method
#744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
Nana-EC
requested changes
Dec 5, 2022
Signed-off-by: georgi-l95 <[email protected]>
Added tests for no |
Codecov ReportBase: 72.53% // Head: 72.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 72.53% 72.71% +0.18%
==========================================
Files 16 16
Lines 1227 1228 +1
Branches 224 225 +1
==========================================
+ Hits 890 893 +3
+ Misses 279 278 -1
+ Partials 58 57 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: georgi-l95 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
georgi-l95
deleted the
742-empty-to-parameter-in-eth_call-causes-relay-to-interrupt-deployment
branch
lukelee-sl
pushed a commit
that referenced
this pull request
Dec 6, 2022
Checks if to parameter is passed in eth_call method, before checking it's length. Signed-off-by: georgi-l95 <[email protected]>
This was referenced Dec 6, 2022
lukelee-sl
added a commit
that referenced
this pull request
Dec 6, 2022
* Check `to` parameter in `eth_call` method (#744) Checks if to parameter is passed in eth_call method, before checking it's length. Signed-off-by: georgi-l95 <[email protected]> * eth_getBalance workaround (#717) * feat: add workaround logic Signed-off-by: Ivo Yankov <[email protected]> * fix: unit tests Signed-off-by: Ivo Yankov <[email protected]> * chore: code cleanup Signed-off-by: Ivo Yankov <[email protected]> * test: add acceptance test Signed-off-by: Ivo Yankov <[email protected]> * chore: fix unit tests Signed-off-by: Ivo Yankov <[email protected]> * refactor: remove duplicated pagination util Signed-off-by: Ivo Yankov <[email protected]> * fix: add safeguard against double link prefix Signed-off-by: Ivo Yankov <[email protected]> * chore: fix acceptancetest api tests structure Signed-off-by: Ivo Yankov <[email protected]> * nit: code cleanup Signed-off-by: Ivo Yankov <[email protected]> * fix: calculate balance at block end Signed-off-by: Ivo Yankov <[email protected]> * fix: broken unit tests Signed-off-by: Ivo Yankov <[email protected]> * test: add explicit unit texts for balance calculation Signed-off-by: Ivo Yankov <[email protected]> * fix: tweak unit tests Signed-off-by: Ivo Yankov <[email protected]> * fix: failing acceptance test Signed-off-by: Ivo Yankov <[email protected]> * fix: failing acceptance test Signed-off-by: Ivo Yankov <[email protected]> * fix: failing tests Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: georgi-l95 <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Co-authored-by: georgi-l95 <[email protected]> Co-authored-by: Ivo Yankov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: georgi-l95 [email protected]
Description:
Checks if
toparameter is passed ineth_callmethod, before checking it's length.Related issue(s):
Fixes #742
Notes for reviewer:
Checklist