Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick updates for v0.13.1 #752

Closed
wants to merge 10 commits into from
Closed

Cherry pick updates for v0.13.1 #752

wants to merge 10 commits into from

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick the following commits to including into version 0.13.1
#717 #744

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

lukelee-sl and others added 10 commits November 29, 2022 16:59
* Bump 0.13.0-rc1

Signed-off-by: lukelee-sl <[email protected]>

* update rpc spec link url

Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
* bump sdk version to 2.19.0 (#726)

Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>

* Bump Test Images version (#718)

- Bump network node image version to `0.32.0`
- Bump mirror node image version to `0.69.0`
- Fix health/readiness always `DOWN`
- `setApproveForAll` action is not working with this image.
- `updateTokenInfo` tests changed to update only token info, not token keys.

Signed-off-by: georgi-l95 <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Co-authored-by: georgi-l95 <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
* Handle empty state_change array in contract details

Signed-off-by: lukelee-sl <[email protected]>

* update errors to use predefined errors

Signed-off-by: lukelee-sl <[email protected]>

* remove redundant null check

Signed-off-by: lukelee-sl <[email protected]>

add utility function for brevity and clarity

Signed-off-by: lukelee-sl <[email protected]>

remove unused import

Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
Return 32 byte 0 on empty state_changes array (#738)

* Return 32 byte 0 on empty state_changes array

Signed-off-by: lukelee-sl <[email protected]>

* remove unnecessary optional chaining operator

Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>

Signed-off-by: lukelee-sl <[email protected]>
Checks if to parameter is passed in eth_call method, before checking it's length.

Signed-off-by: georgi-l95 <[email protected]>
* feat: add workaround logic

Signed-off-by: Ivo Yankov <[email protected]>

* fix: unit tests

Signed-off-by: Ivo Yankov <[email protected]>

* chore: code cleanup

Signed-off-by: Ivo Yankov <[email protected]>

* test: add acceptance test

Signed-off-by: Ivo Yankov <[email protected]>

* chore: fix unit tests

Signed-off-by: Ivo Yankov <[email protected]>

* refactor: remove duplicated pagination util

Signed-off-by: Ivo Yankov <[email protected]>

* fix: add safeguard against double link prefix

Signed-off-by: Ivo Yankov <[email protected]>

* chore: fix acceptancetest api tests structure

Signed-off-by: Ivo Yankov <[email protected]>

* nit: code cleanup

Signed-off-by: Ivo Yankov <[email protected]>

* fix: calculate balance at block end

Signed-off-by: Ivo Yankov <[email protected]>

* fix: broken unit tests

Signed-off-by: Ivo Yankov <[email protected]>

* test: add explicit unit texts for balance calculation

Signed-off-by: Ivo Yankov <[email protected]>

* fix: tweak unit tests

Signed-off-by: Ivo Yankov <[email protected]>

* fix: failing acceptance test

Signed-off-by: Ivo Yankov <[email protected]>

* fix: failing acceptance test

Signed-off-by: Ivo Yankov <[email protected]>

* fix: failing tests

Signed-off-by: Ivo Yankov <[email protected]>

Signed-off-by: Ivo Yankov <[email protected]>
@lukelee-sl lukelee-sl added enhancement New feature or request P1 process Build, test and deployment-process related tasks labels Dec 6, 2022
@lukelee-sl lukelee-sl added this to the 0.13.1 milestone Dec 6, 2022
@lukelee-sl lukelee-sl self-assigned this Dec 6, 2022
@lukelee-sl lukelee-sl closed this Dec 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lukelee-sl lukelee-sl deleted the cherry-pick-13.1 branch December 6, 2022 21:33
@lukelee-sl lukelee-sl restored the cherry-pick-13.1 branch December 6, 2022 21:33
@lukelee-sl lukelee-sl deleted the cherry-pick-13.1 branch December 6, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants