Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update HAProxy UP check to use HAProxy Data Plane API #173

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • update HAProxy UP check to use HAProxy Data Plane API

Related Issues

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Unit Test Results

  1 files  ±0   16 suites  ±0   1m 8s ⏱️ -11s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
134 runs  ±0  134 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f85e60b. ± Comparison against base commit feba5f9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

E2E Test Results

55 tests  +2   55 ✅ +2   6m 6s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f85e60b. ± Comparison against base commit feba5f9.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon force-pushed the 00169-haproxy-health-check branch from 0ede4ee to dc2e9b4 Compare March 21, 2024 14:30
commit 0ede4ee
Author: Jeromy Cannon <[email protected]>
Date:   Wed Mar 20 21:54:30 2024 +0000

    timeout fetch plus log messages

    Signed-off-by: Jeromy Cannon <[email protected]>

commit abdabc2
Author: Jeromy Cannon <[email protected]>
Date:   Wed Mar 20 21:32:36 2024 +0000

    fix check failure

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 6369895
Author: Jeromy Cannon <[email protected]>
Date:   Wed Mar 20 20:55:24 2024 +0000

    working version

    Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon force-pushed the 00169-haproxy-health-check branch from dc2e9b4 to a907f45 Compare March 21, 2024 14:35
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Copy link

codacy-production bot commented Mar 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% (target: -1.00%) 83.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (feba5f9) 2564 1786 69.66%
Head commit (f85e60b) 2591 (+27) 1806 (+20) 69.70% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#173) 49 41 83.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 69.14%. Comparing base (feba5f9) to head (f85e60b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   69.13%   69.14%   +0.01%     
==========================================
  Files          32       32              
  Lines        3068     3095      +27     
  Branches      473      478       +5     
==========================================
+ Hits         2121     2140      +19     
- Misses        947      955       +8     
Files Coverage Δ
src/core/account_manager.mjs 76.41% <100.00%> (-1.48%) ⬇️
src/core/constants.mjs 93.50% <100.00%> (+0.26%) ⬆️
src/core/k8.mjs 84.87% <100.00%> (+0.58%) ⬆️
version.mjs 100.00% <100.00%> (ø)
src/commands/node.mjs 68.50% <75.67%> (-0.04%) ⬇️

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review March 21, 2024 16:05
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners March 21, 2024 16:05
src/core/k8.mjs Outdated Show resolved Hide resolved
src/core/k8.mjs Outdated Show resolved Hide resolved
src/commands/node.mjs Outdated Show resolved Hide resolved
Copy link
Member

@leninmehedy leninmehedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very important fix.

@jeromy-cannon jeromy-cannon merged commit a27d1d2 into main Mar 22, 2024
19 checks passed
@jeromy-cannon jeromy-cannon deleted the 00169-haproxy-health-check branch March 22, 2024 12:17
swirlds-automation added a commit that referenced this pull request Mar 22, 2024
## [0.22.1](v0.22.0...v0.22.1) (2024-03-22)

### Bug Fixes

* download JRE for keytool dependency and allow generation of pfx keys ([#152](#152)) ([1d3dcf4](1d3dcf4))
* refactor account initialization and mirror node setup from node command ([#159](#159)) ([b1d1e2d](b1d1e2d))
* solo should use a fixed FST chart version ([#139](#139)) ([b0d5f8b](b0d5f8b))
* update HAProxy UP check to use HAProxy Data Plane API ([#173](#173)) ([a27d1d2](a27d1d2))
* use FST chart version v0.23.0 ([#170](#170)) ([54efab3](54efab3))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HAProxy UP check is unreliable
3 participants