fix: refactor account initialization and mirror node setup from node command #159

leninmehedy · 2024-03-13T05:23:29Z

Description

This pull request changes the following:

Isolate account initialization and mirror node setup from node command
Remove unnecessary socket cleanup code (_stopPortForwards) as the actual issue was with hedera-sdk-js:
- See: A new logger is instantiated every time a method is invoked hiero-ledger/hiero-sdk-js#2194
Make node-command and account-command e2e tests independent from each other (i.e. use separate namespaces)
Remove unused function resetHapiDirectories to avoid test errors: Fix test error #151

Related Issues

Closes Refactor account keys update into Account Command #143
Closes Implement mirror-node command #116
Closes solo node start does not terminate #153
Closes Upgrade Hedera JS SDK #165
Closes Fix test error #151

Todo:

… making it killable Signed-off-by: Lenin Mehedy <[email protected]>

Signed-off-by: Lenin Mehedy <[email protected]>

github-actions · 2024-03-13T05:28:03Z

Unit Test Results

1 files ±0 14 suites ±0 24s ⏱️ -1s
91 tests ±0 91 ✅ ±0 0 💤 ±0 0 ❌ ±0
98 runs ±0 98 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 8bca857. ± Comparison against base commit b0d5f8b.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-13T05:34:36Z

E2E Test Results

1 files ± 0 7 suites +1 4m 27s ⏱️ - 1m 34s
47 tests - 689 47 ✅ - 688 0 💤 ±0 0 ❌ - 1
47 runs - 688 47 ✅ - 687 0 💤 ±0 0 ❌ - 1

Results for commit 8bca857. ± Comparison against base commit b0d5f8b.

This pull request removes 713 and adds 24 tests. Note that renamed tests count towards both.

NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] checkNetworkNodeProxyUp should succeed ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] checkNetworkNodeProxyUp should succeed
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] node setup should succeed ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] node setup should succeed
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] node start should succeed ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] node start should succeed
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 10 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 10 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 100 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 100 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 1000 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 1000 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 11 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 11 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 12 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 12 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 13 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 13 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 14 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 14 should not have genesis key
…

AccountCommand Bootstrap network for test should cleanup previous deployment ‑ AccountCommand Bootstrap network for test should cleanup previous deployment
AccountCommand Bootstrap network for test should succeed with network deploy ‑ AccountCommand Bootstrap network for test should succeed with network deploy
AccountCommand Bootstrap network for test should succeed with node setup command ‑ AccountCommand Bootstrap network for test should succeed with node setup command
AccountCommand Bootstrap network for test should succeed with node start command ‑ AccountCommand Bootstrap network for test should succeed with node start command
AccountCommand account create/update command should be able to get account-1 ‑ AccountCommand account create/update command should be able to get account-1
AccountCommand account create/update command should be able to get account-2 ‑ AccountCommand account create/update command should be able to get account-2
AccountCommand account create/update command should create account with no options ‑ AccountCommand account create/update command should create account with no options
AccountCommand account create/update command should create account with private key and hbar amount options ‑ AccountCommand account create/update command should create account with private key and hbar amount options
AccountCommand account create/update command should update account-1 ‑ AccountCommand account create/update command should update account-1
AccountCommand account create/update command should update account-2 with accountId, amount, new private key, and standard out options ‑ AccountCommand account create/update command should update account-2 with accountId, amount, new private key, and standard out options
…

♻️ This comment has been updated with latest results.

Signed-off-by: Lenin Mehedy <[email protected]>

codacy-production · 2024-03-14T04:24:39Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `b0d5f8b`¹	✅ 53.91%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`b0d5f8b`)	Report Missing	Report Missing	Report Missing
Head commit (`8bca857`)	2408	1596	66.28%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#159)	243	131	53.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-03-14T04:25:01Z

Codecov Report

Attention: Patch coverage is 54.03509% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 65.88%. Comparing base (1226817) to head (8bca857).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   65.55%   65.88%   +0.33%     
==========================================
  Files          29       30       +1     
  Lines        2720     2864     +144     
  Branches      414      488      +74     
==========================================
+ Hits         1783     1887     +104     
- Misses        937      977      +40

Files	Coverage Δ
src/commands/flags.mjs	`94.00% <ø> (ø)`
src/commands/network.mjs	`34.45% <ø> (+34.45%)`	⬆️
src/core/config_manager.mjs	`91.56% <100.00%> (ø)`
src/core/helm.mjs	`90.47% <100.00%> (+1.00%)`	⬆️
src/core/platform_installer.mjs	`89.50% <100.00%> (-0.03%)`	⬇️
src/commands/index.mjs	`0.00% <0.00%> (ø)`
src/commands/node.mjs	`56.42% <90.90%> (+0.17%)`	⬆️
src/core/constants.mjs	`92.75% <80.00%> (+0.32%)`	⬆️
src/core/account_manager.mjs	`77.88% <91.30%> (-7.77%)`	⬇️
src/core/chart_manager.mjs	`62.50% <0.00%> (+14.06%)`	⬆️
... and 5 more

... and 3 files with indirect coverage changes

Signed-off-by: Lenin Mehedy <[email protected]>

test: remove unused function `resetHapiDirectories` to avoid test errors Signed-off-by: Lenin Mehedy <[email protected]> #151

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy · 2024-03-18T11:31:54Z

0.00% <0.00%> (ø)

src/commands/mirror_node.mjs 0.00% <0.00%> (ø)

Need to implement test/e2e/mirror_node_e2e.test.mjs

src/core/account_manager.mjs

src/core/k8.mjs

src/core/constants.mjs

Signed-off-by: Lenin Mehedy <[email protected]>

## [0.22.1](v0.22.0...v0.22.1) (2024-03-22) ### Bug Fixes * download JRE for keytool dependency and allow generation of pfx keys ([#152](#152)) ([1d3dcf4](1d3dcf4)) * refactor account initialization and mirror node setup from node command ([#159](#159)) ([b1d1e2d](b1d1e2d)) * solo should use a fixed FST chart version ([#139](#139)) ([b0d5f8b](b0d5f8b)) * update HAProxy UP check to use HAProxy Data Plane API ([#173](#173)) ([a27d1d2](a27d1d2)) * use FST chart version v0.23.0 ([#170](#170)) ([54efab3](54efab3))

swirlds-automation · 2024-03-22T15:09:08Z

🎉 This PR is included in version 0.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

leninmehedy added 4 commits March 12, 2024 23:44

fix: use stoppable to stop port-forward servers gracefully instead of…

f78934e

… making it killable Signed-off-by: Lenin Mehedy <[email protected]>

fix: refactor system account update as account init command

1770fda

Signed-off-by: Lenin Mehedy <[email protected]>

fix: refactor mirror node setup into a mirror-node command

dbb8045

Signed-off-by: Lenin Mehedy <[email protected]>

no need to use stoppable

d43de69

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy requested review from a team as code owners March 13, 2024 05:23

leninmehedy requested a review from nathanklick March 13, 2024 05:23

leninmehedy changed the title ~~fix: isolate account initialization and mirror node setup from node command~~ fix: refactor account initialization and mirror node setup from node command Mar 13, 2024

leninmehedy force-pushed the 153-143-create-account-command branch 2 times, most recently from ee8fcc8 to 6e34fc1 Compare March 13, 2024 22:40

leninmehedy added 2 commits March 14, 2024 10:05

add more test

9891210

Signed-off-by: Lenin Mehedy <[email protected]>

ci: test with fst chart version v0.22.0

e14d1c3

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy force-pushed the 153-143-create-account-command branch from 6e34fc1 to e14d1c3 Compare March 13, 2024 23:06

fix test

eaba77b

Signed-off-by: Lenin Mehedy <[email protected]>

fix: make node command test self contained

0140722

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy requested a review from jeromy-cannon March 15, 2024 07:00

leninmehedy force-pushed the 153-143-create-account-command branch from 6c8e903 to d4ee604 Compare March 15, 2024 10:29

leninmehedy added 3 commits March 15, 2024 21:31

fix: make account command test self contained

caacca9

Signed-off-by: Lenin Mehedy <[email protected]>

Merge branch 'main' into 153-143-create-account-command

3922f25

use FST_CHART_VERSION from version file

e2ff6a7

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy marked this pull request as draft March 15, 2024 10:42

leninmehedy force-pushed the 153-143-create-account-command branch from d4ee604 to c9c2dde Compare March 15, 2024 10:59

fix timeout and logs

0ad0610

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy force-pushed the 153-143-create-account-command branch from c9c2dde to 0ad0610 Compare March 15, 2024 12:43

fix:

8da1058

test: remove unused function `resetHapiDirectories` to avoid test errors Signed-off-by: Lenin Mehedy <[email protected]> #151

leninmehedy marked this pull request as ready for review March 18, 2024 03:59

leninmehedy force-pushed the 153-143-create-account-command branch from 544a3c0 to c6474de Compare March 18, 2024 11:05

fix: refactor bootstrapNetwork method for reusability

47ce2ac

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy force-pushed the 153-143-create-account-command branch from c6474de to 47ce2ac Compare March 18, 2024 11:21

jeromy-cannon reviewed Mar 18, 2024

View reviewed changes

src/core/account_manager.mjs Show resolved Hide resolved

jeromy-cannon reviewed Mar 18, 2024

View reviewed changes

src/core/account_manager.mjs Show resolved Hide resolved

jeromy-cannon reviewed Mar 18, 2024

View reviewed changes

src/core/k8.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed Mar 18, 2024

View reviewed changes

src/core/constants.mjs Show resolved Hide resolved

jeromy-cannon assigned leninmehedy Mar 18, 2024

leninmehedy added 2 commits March 19, 2024 14:06

fix: return a promise to handle closing port forwarder

353d67c

Signed-off-by: Lenin Mehedy <[email protected]>

fix: update accounts in parallel

8bca857

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy requested a review from jeromy-cannon March 19, 2024 03:46

jeromy-cannon approved these changes Mar 19, 2024

View reviewed changes

jeromy-cannon merged commit b1d1e2d into main Mar 19, 2024
16 of 17 checks passed

jeromy-cannon deleted the 153-143-create-account-command branch March 19, 2024 07:53

swirlds-automation added the released label Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: refactor account initialization and mirror node setup from node command #159

fix: refactor account initialization and mirror node setup from node command #159

leninmehedy commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 13, 2024 •

edited

Loading

codacy-production bot commented Mar 14, 2024 •

edited

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading

leninmehedy commented Mar 18, 2024 •

edited

Loading

swirlds-automation commented Mar 22, 2024

fix: refactor account initialization and mirror node setup from node command #159

fix: refactor account initialization and mirror node setup from node command #159

Conversation

leninmehedy commented Mar 13, 2024 • edited Loading

Description

Related Issues

Todo:

github-actions bot commented Mar 13, 2024 • edited Loading

Unit Test Results

github-actions bot commented Mar 13, 2024 • edited Loading

E2E Test Results

codacy-production bot commented Mar 14, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Mar 14, 2024 • edited Loading

Codecov Report

leninmehedy commented Mar 18, 2024 • edited Loading

swirlds-automation commented Mar 22, 2024

leninmehedy commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 13, 2024 •

edited

Loading

codacy-production bot commented Mar 14, 2024 •

edited

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading

leninmehedy commented Mar 18, 2024 •

edited

Loading