Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solo should use a fixed FST chart version #139

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

leninmehedy
Copy link
Member

Description

This pull request changes the following:

  • fix: solo should use a fixed FST chart version

Related Issues

@leninmehedy leninmehedy requested review from a team as code owners March 6, 2024 23:44
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Unit Test Results

 1 files  ±0  14 suites  ±0   24s ⏱️ ±0s
91 tests ±0  91 ✅ ±0  0 💤 ±0  0 ❌ ±0 
98 runs  ±0  98 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e00c8fd. ± Comparison against base commit 1226817.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

E2E Test Results

736 tests  ±0   736 ✅ ±0   13m 1s ⏱️ +10s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e00c8fd. ± Comparison against base commit 1226817.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Mar 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1226817) 2284 1505 65.89%
Head commit (e00c8fd) 2286 (+2) 1507 (+2) 65.92% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#139) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (1226817) to head (e00c8fd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   65.55%   65.56%   +0.01%     
==========================================
  Files          29       29              
  Lines        2720     2721       +1     
  Branches      414      466      +52     
==========================================
+ Hits         1783     1784       +1     
  Misses        937      937              
Files Coverage Δ
src/commands/flags.mjs 94.00% <ø> (ø)
version.mjs 100.00% <100.00%> (ø)

Impacted file tree graph

nathanklick
nathanklick previously approved these changes Mar 7, 2024
@leninmehedy leninmehedy force-pushed the 109-add-fst-chart-version branch from 8523ab8 to 4950377 Compare March 7, 2024 02:39
Base automatically changed from 00048-helm-binary to main March 7, 2024 03:42
@leninmehedy leninmehedy dismissed nathanklick’s stale review March 7, 2024 03:42

The base branch was changed.

@leninmehedy leninmehedy force-pushed the 109-add-fst-chart-version branch from 4950377 to 6bb72eb Compare March 7, 2024 03:44
@leninmehedy leninmehedy merged commit b0d5f8b into main Mar 14, 2024
19 checks passed
@leninmehedy leninmehedy deleted the 109-add-fst-chart-version branch March 14, 2024 06:13
swirlds-automation added a commit that referenced this pull request Mar 22, 2024
## [0.22.1](v0.22.0...v0.22.1) (2024-03-22)

### Bug Fixes

* download JRE for keytool dependency and allow generation of pfx keys ([#152](#152)) ([1d3dcf4](1d3dcf4))
* refactor account initialization and mirror node setup from node command ([#159](#159)) ([b1d1e2d](b1d1e2d))
* solo should use a fixed FST chart version ([#139](#139)) ([b0d5f8b](b0d5f8b))
* update HAProxy UP check to use HAProxy Data Plane API ([#173](#173)) ([a27d1d2](a27d1d2))
* use FST chart version v0.23.0 ([#170](#170)) ([54efab3](54efab3))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solo should use a default FST chart version
4 participants