Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set custom resources for *uploader containers #926

Closed
alex-kuzmin-hg opened this issue Dec 5, 2024 · 2 comments · Fixed by #957
Closed

Cannot set custom resources for *uploader containers #926

alex-kuzmin-hg opened this issue Dec 5, 2024 · 2 comments · Fixed by #957
Assignees
@JeffreyDallas
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Internal Requirement released

Comments

@alex-kuzmin-hg
Copy link
Contributor

alex-kuzmin-hg commented Dec 5, 2024 •
edited by nathanklick
Loading

Describe the bug

It is impossible to modify resource values for containers *-uploader
via external init-container-values.yml

We must have a mechanism of updating, because default values do not fit.

Describe the expected behavior

To let user modify input value file

To Reproduce

Currently, the values for *-uploaders ignored:

  1. modify init-containers-values.yaml
  2. call
    ~/.solo/bin/helm template solo-deployment oci://ghcr.io/hashgraph/solo-charts/solo-deployment --version 0.34.0 -n solo-test2 --create-namespace --values ~/.solo/cache/values-files/solo-local.yaml --set "telemetry.prometheus.svcMonitor.enabled=false" --set "defaults.root.image.repository=hashgraph/solo-containers/ubi8-init-java21" --set "defaults.volumeClaims.enabled=false" --values ./init-containers-values.yaml
  3. no resources taken

Additional Context

No response
@alex-kuzmin-hg alex-kuzmin-hg added Bug A error that causes the feature to behave differently than what was expected based on design docs Pending Triage New issue that needs to be triaged by the team labels Dec 5, 2024
@jeromy-cannon jeromy-cannon added P0 An issue impacting production environments or impacting multiple releases or multiple individuals. Internal Requirement P1 High priority issue. Required to be completed in the assigned milestone. and removed Pending Triage New issue that needs to be triaged by the team P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Dec 5, 2024
@alex-kuzmin-hg alex-kuzmin-hg removed the P1 High priority issue. Required to be completed in the assigned milestone. label Dec 5, 2024
@JeffreyDallas
Copy link
Contributor

@alex-kuzmin-hg
I am closing the ticket since I verified that we should be able to set resources for each indvidual containers

  nodes:
    - name: node1
      accountId: 0.0.3
      sidecars:
        recordStreamSidecarUploader:
          enabled: true
          resources:
            requests:
              cpu: 1m
              memory: 2Mi
            limits:
              cpu: 3m
              memory: 4Mi
    - name: node2
      accountId: 0.0.4
      sidecars:
        recordStreamSidecarUploader:
          enabled: true
          resources:
            requests:
              cpu: 1m
              memory: 2Mi
            limits:
              cpu: 3m
              memory: 4Mi

The key is to add enabled: true to each individual uploader, otherwise it will not be instantiated.

@alex-kuzmin-hg alex-kuzmin-hg mentioned this issue Dec 9, 2024
Merged
jeromy-cannon added a commit that referenced this issue Dec 10, 2024
@alex-kuzmin-hg @jeromy-cannon
fix: Examples of performance configs for HashSphere and Latitude (#926)…
928148b 
… (#957)

Signed-off-by: Alex Kuzmin <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
@hashgraph hashgraph deleted a comment from alex-kuzmin-hg Dec 16, 2024
swirlds-automation added a commit that referenced this issue Dec 31, 2024
@swirlds-automation
chore(release): 0.32.0 [skip ci]
3d074b1 
## [0.32.0](v0.31.1...v0.32.0) (2024-12-31)

### ⚠ BREAKING CHANGES

* update readme with warning about BREAKING CHANGE in this next release (#730)

### Features

* add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341))
* add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e))
* add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7))
* add separate commands for update ([#735](#735)) ([44c3132](44c3132))
* add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0))
* add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad))
* Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38))
* add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b))
* allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e))
* change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496))
* Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d))
* Create remote config  ([#862](#862)) ([e8fe739](e8fe739))
* dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6))
* expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279))
* Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b))
* Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec))
* Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275))
* **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089))
* new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18))
* removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3))
* Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320))
* update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5))
* Update document ([#956](#956)) ([b378937](b378937))
* update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc))
* Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0))

### Bug Fixes

* add delay before calling script ([#955](#955)) ([76f4b81](76f4b81))
* allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78))
* bump chart and hedera version,  re-enable node add ([#985](#985)) ([9cae011](9cae011))
* check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab))
* document typo ([#988](#988)) ([8e4fe04](8e4fe04))
* Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5))
* Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b))
* fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1))
* fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516))
* flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0))
* inconsistent failures ([#866](#866)) ([13ea46d](13ea46d))
* local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1))
* nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6))
* node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5))
* node update with single node ([#981](#981)) ([74285bf](74285bf))
* patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989))
* performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6))
* refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99))
* remote config validation not working ([#967](#967)) ([88c2506](88c2506))
* resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652))
* Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3))
* undefined log output of namespace ([#764](#764)) ([ac15957](ac15957))

### Documentation

* update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDallas JeffreyDallas

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Internal Requirement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Examples of performance configs for 4-core and Latitude (#926) hashgraph/solo
4 participants
@jeromy-cannon @JeffreyDallas @swirlds-automation @alex-kuzmin-hg