feat: add timeout flag to network destroy command #821

JeffreyDallas · 2024-11-12T01:20:14Z

Description

This pull request changes the following:

Consolidate the three mini tasks of installing char, deleting secrets and pvs into a single task
Wrap the new task with timeout logic, set networkDestorySuccess to false if tmeout triggered

Related Issues

Closes Add a timeout flag for the network command destroy subcommand #815

Test output, when giving a small timeout value, the output looks like following:

...
******************************* Solo *********************************************
Version			: 0.99.0
Kubernetes Context	: kind-solo-e2e
Kubernetes Cluster	: kind-solo-e2e
Kubernetes Namespace	: solo-e2e
**********************************************************************************
✔ Initialize
  ✔ Acquire lease - lease acquired successfully, attempt: 1/10
✔ Deleting secrets in namespace solo-e2e [0.7s]



Unable to finish network destroy in 0.3 seconds


$:~/solo$ echo $?
1

Signed-off-by: Jeffrey Tang <[email protected]>

github-actions · 2024-11-12T01:23:13Z

Unit Test Results - Linux

1 files ±0 36 suites ±0 4s ⏱️ -1s
109 tests ±0 109 ✅ ±0 0 💤 ±0 0 ❌ ±0
118 runs ±0 118 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5da267a. ± Comparison against base commit 13ea46d.

♻️ This comment has been updated with latest results.

github-actions · 2024-11-12T01:23:19Z

Unit Test Results - Windows

1 files ±0 36 suites ±0 12s ⏱️ -3s
109 tests ±0 109 ✅ ±0 0 💤 ±0 0 ❌ ±0
118 runs ±0 118 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5da267a. ± Comparison against base commit 13ea46d.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <[email protected]>

src/commands/network.ts

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon · 2024-11-21T09:56:38Z

merge conflicts

…timeout-flag Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/network.ts

github-actions · 2024-11-21T16:55:23Z

E2E Test Report

16 files 109 suites 1h 16m 32s ⏱️
231 tests 231 ✅ 0 💤 0 ❌
234 runs 234 ✅ 0 💤 0 ❌

Results for commit 751cc08.

github-actions · 2024-11-21T16:55:23Z

E2E Test Report

13 files ±0 94 suites ±0 53m 27s ⏱️ -3s
198 tests ±0 198 ✅ ±0 0 💤 ±0 0 ❌ ±0
201 runs ±0 201 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5da267a. ± Comparison against base commit 13ea46d.

♻️ This comment has been updated with latest results.

codacy-production · 2024-11-21T16:55:37Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.03% (target: -1.00%)	✅ 79.10%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`13ea46d`)	14741	12527	84.98%
Head commit (`5da267a`)	14804 (+63)	12576 (+49)	84.95% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#821)	67	53	79.10%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

src/commands/network.ts

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

…timeout-flag Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/core/constants.ts

…timeout-flag Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # examples/custom-network-config/Taskfile.yml

Signed-off-by: Jeffrey Tang <[email protected]>

codecov · 2024-11-25T15:21:27Z

Codecov Report

Attention: Patch coverage is 77.61194% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (13ea46d) to head (5da267a).
Report is 103 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/network.ts	72.72%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   83.82%   83.76%   -0.07%     
==========================================
  Files          49       49              
  Lines       14769    14804      +35     
  Branches     1301     1040     -261     
==========================================
+ Hits        12380    12400      +20     
- Misses       2280     2374      +94     
+ Partials      109       30      -79

Files with missing lines	Coverage Δ
src/commands/flags.ts	`99.56% <100.00%> (+<0.01%)`	⬆️
src/core/constants.ts	`96.73% <100.00%> (+0.01%)`	⬆️
src/commands/network.ts	`74.32% <72.72%> (-1.41%)`	⬇️

... and 23 files with indirect coverage changes

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:31:05Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas added 2 commits November 11, 2024 14:14

add timeout flag

4f18f25

Signed-off-by: Jeffrey Tang <[email protected]>

check if timeout enabled

cc4aabc

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested review from leninmehedy and a team as code owners November 12, 2024 01:20

JeffreyDallas self-assigned this Nov 12, 2024

JeffreyDallas marked this pull request as draft November 12, 2024 01:20

JeffreyDallas changed the title ~~00815 d timeout flag~~ feat: add timeout flag to network destroy command Nov 12, 2024

JeffreyDallas added 2 commits November 11, 2024 23:01

save

3a38542

Signed-off-by: Jeffrey Tang <[email protected]>

fix: timeout unit

9bf7bc6

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas marked this pull request as ready for review November 12, 2024 15:20

JeffreyDallas added 2 commits November 12, 2024 09:20

Merge branch 'main' into 00815-D-timeout-flag

3a7456b

Merge branch 'main' into 00815-D-timeout-flag

2e325cf

JeffreyDallas requested a review from jeromy-cannon November 14, 2024 15:28

jeromy-cannon reviewed Nov 19, 2024

View reviewed changes

src/commands/network.ts Outdated Show resolved Hide resolved

jeromy-cannon reviewed Nov 19, 2024

View reviewed changes

src/commands/network.ts Outdated Show resolved Hide resolved

jeromy-cannon reviewed Nov 19, 2024

View reviewed changes

src/commands/network.ts Show resolved Hide resolved

jeromy-cannon reviewed Nov 19, 2024

View reviewed changes

src/commands/network.ts Outdated Show resolved Hide resolved

JeffreyDallas and others added 6 commits November 19, 2024 12:45

Update src/commands/network.ts

d7b71f9

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update src/commands/network.ts

4b83fa7

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update src/commands/network.ts

25f56c5

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update src/commands/network.ts

46f1fff

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Merge branch 'main' into 00815-D-timeout-flag

075b273

add force to config

ac54f49

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit '7fa86ad19c66d2ea98d4d10b0400b1635499c322' into 00815-D-…

751cc08

…timeout-flag Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/network.ts

jeromy-cannon reviewed Nov 22, 2024

View reviewed changes

src/commands/network.ts Outdated Show resolved Hide resolved

JeffreyDallas and others added 2 commits November 22, 2024 09:32

Update src/commands/network.ts

c0dc003

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Merge commit '5e1c6527a0f033ad84ce5551df0d7c2d414d9e1b' into 00815-D-…

f19f5fb

…timeout-flag Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/core/constants.ts

jeromy-cannon previously approved these changes Nov 22, 2024

View reviewed changes

Merge commit '1d9452e2400b8fdbf58bb739391143ad215481e6' into 00815-D-…

828b223

…timeout-flag Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # examples/custom-network-config/Taskfile.yml

JeffreyDallas dismissed jeromy-cannon’s stale review via 828b223 November 22, 2024 20:55

remove extra line

8922e32

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon approved these changes Nov 22, 2024

View reviewed changes

Merge branch 'main' into 00815-D-timeout-flag

5da267a

JeffreyDallas merged commit 0fb570b into main Nov 25, 2024
37 of 39 checks passed

JeffreyDallas deleted the 00815-D-timeout-flag branch November 25, 2024 15:23

swirlds-automation added the released label Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add timeout flag to network destroy command #821

feat: add timeout flag to network destroy command #821

JeffreyDallas commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024 •

edited

Loading

jeromy-cannon commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024 •

edited

Loading

codacy-production bot commented Nov 21, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

swirlds-automation commented Dec 31, 2024

feat: add timeout flag to network destroy command #821

feat: add timeout flag to network destroy command #821

Conversation

JeffreyDallas commented Nov 12, 2024 • edited Loading

Description

Related Issues

Test output, when giving a small timeout value, the output looks like following:

github-actions bot commented Nov 12, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Nov 12, 2024 • edited Loading

Unit Test Results - Windows

jeromy-cannon commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

E2E Test Report

github-actions bot commented Nov 21, 2024 • edited Loading

E2E Test Report

codacy-production bot commented Nov 21, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

swirlds-automation commented Dec 31, 2024

JeffreyDallas commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 21, 2024 •

edited

Loading

codacy-production bot commented Nov 21, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading