NET-6663 Set gateway-kind in Workload metadata when it represents a xGateway Pod #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
theme/mesh-gw
pr/no-changelog
nathancoleman
changed the title
4 tasks
nathancoleman
requested review from
DanStough,
a team,
andrewstucki and
sarahalsmiller
and removed request for
a team
By setting the gateway-kind annotation on the Pods for a MeshGateway, we indicate to the Pod controller in consul-k8s that the Pod represents a mesh gateway (or api/terminating in the future). The Pod controller then passes this along as metadata on the Workload that it creates in Consul. The end result is that the sidecar and gateway proxy controllers can determine which Workloads they should generate ProxyStateTemplates for.
nathancoleman
force-pushed
the
workload-meta-gateway-kind
branch
from
5d6854f to
d9e35cb
Compare
sarahalsmiller
approved these changes
Dec 14, 2023
jm96441n
reviewed
Dec 14, 2023
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
…Gateway Pod (#3365) Set gateway-kind in Workload metadata when it represents a xGateway Pod By setting the gateway-kind annotation on the Pods for a MeshGateway, we indicate to the Pod controller in consul-k8s that the Pod represents a mesh gateway (or api/terminating in the future). The Pod controller then passes this along as metadata on the Workload that it creates in Consul. The end result is that the sidecar and gateway proxy controllers can determine which Workloads they should generate ProxyStateTemplates for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
By setting the gateway-kind annotation on the Pods for a MeshGateway, we indicate to the Pod controller in consul-k8s that the Pod represents a mesh gateway (or api/terminating in the future). The Pod controller then passes this along as metadata on the Workload that it creates in Consul.
The end result is that the sidecar and gateway proxy controllers can determine which Workloads they should generate ProxyStateTemplates for and which should be left to the other.
How I've tested this PR
When combined with hashicorp/consul#19902, the sidecar proxy controller should skip any Workloads created for a
MeshGatewaywhenmeshGateway.enabled=trueandexperiments: [resource-apis]in values.yaml.How I expect reviewers to test this PR
See above
Checklist