Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-6663 Modify sidecarproxy controller to skip xGateway resources #19902

Merged
merged 4 commits into from
Dec 18, 2023
Merged

NET-6663 Modify sidecarproxy controller to skip xGateway resources #19902

merged 4 commits into from
Dec 18, 2023

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Dec 11, 2023 •
edited
Loading

Description

The sidecarproxy.Controller should skip Workload resources with a gateway-kind specified in the resource metadata. The forthcoming gatewayproxy.Controller will be responsible for managing these.

Testing & Reproduction steps

When combined with hashicorp/consul-k8s#3365, the sidecar proxy controller should skip any Workloads created for a MeshGateway when meshGateway.enabled=true and experiments: [resource-apis] in values.yaml.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@nathancoleman nathancoleman added theme/mesh-gw Track mesh gateway work pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Dec 11, 2023
@nathancoleman nathancoleman mentioned this pull request Dec 12, 2023
Merged
2 tasks
@nathancoleman nathancoleman force-pushed the skip-pst-with-gateway-owner branch from 1319ec4 to 5a94eca Compare December 12, 2023 21:48
@nathancoleman nathancoleman requested review from missylbytes, a team and sarahalsmiller and removed request for a team December 16, 2023 01:56
@nathancoleman nathancoleman marked this pull request as ready for review December 16, 2023 01:57
@nathancoleman nathancoleman force-pushed the skip-pst-with-gateway-owner branch from 6d754a9 to c73c8f8 Compare December 16, 2023 02:49
jm96441n
jm96441n approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathancoleman nathancoleman enabled auto-merge (squash) December 18, 2023 21:47
@nathancoleman nathancoleman merged commit 010bf53 into main Dec 18, 2023
82 checks passed
@nathancoleman nathancoleman deleted the skip-pst-with-gateway-owner branch December 18, 2023 21:54
@nathancoleman nathancoleman mentioned this pull request Dec 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm96441n jm96441n jm96441n approved these changes

@missylbytes missylbytes Awaiting requested review from missylbytes

@sarahalsmiller sarahalsmiller Awaiting requested review from sarahalsmiller sarahalsmiller was automatically assigned from hashicorp/consul-api-gateway

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/mesh-gw Track mesh gateway work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathancoleman @jm96441n