Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grace period from vault config section #1266

Closed
eikenb opened this issue Aug 23, 2019 · 2 comments
Closed

Remove grace period from vault config section #1266

eikenb opened this issue Aug 23, 2019 · 2 comments
Labels
docs vault Related to the Vault integration
Milestone

Comments

@eikenb
Copy link
Contributor

eikenb commented Aug 23, 2019

Now with our updated dependencies Vault no longer uses the grace period, it is officially deprecated as of Vault 0.5.0 (2016). It should be removed from the config documentation and either noted as being deprecated in use in the code or removed entirely.

I'll check with the Vault people about whether we should keep passing it or not. It really depends on if there are still Vault installations out there of versions < 0.5.0. If you happen to use Vault < 0.5.0, please add a comment.

@eikenb eikenb added docs vault Related to the Vault integration needs-investigation labels Aug 23, 2019
@eikenb eikenb added this to the 0.23.0 - Documentation milestone Aug 23, 2019
@eikenb
Copy link
Contributor Author

eikenb commented Aug 23, 2019

I spoke with the Vault team and they said that their users tend to stay pretty recent and they haven't seen any sort of support questions about versions of vault that old in a long time.

I.E. they said maintaining compatibility with that old a release is not necessary and should not be a priority.

@eikenb
Copy link
Contributor Author

eikenb commented Aug 26, 2019

This ticket is just about getting the docs updated as I want to get that done. See #1268 for issue about removing the dead grace code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs vault Related to the Vault integration
Projects
None yet
Development

No branches or pull requests

1 participant