Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code/logic for working with Vault grace #1284

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Sep 20, 2019

Part of #1266 . Remove all the code for the deprecated Vault grace field.

Fixes #1268

Tests:

[consul-template][remove-vault-grace](4)$ make test  
==> Testing consul-template
ok      github.com/hashicorp/consul-template    2.042s
ok      github.com/hashicorp/consul-template/child      1.695s
ok      github.com/hashicorp/consul-template/config     0.121s
ok      github.com/hashicorp/consul-template/dependency 6.181s
ok      github.com/hashicorp/consul-template/logging    0.048s
ok      github.com/hashicorp/consul-template/manager    3.334s
ok      github.com/hashicorp/consul-template/renderer   0.102s
ok      github.com/hashicorp/consul-template/signals    0.036s
ok      github.com/hashicorp/consul-template/template   0.120s
?       github.com/hashicorp/consul-template/test       [no test files]
?       github.com/hashicorp/consul-template/version    [no test files]
ok      github.com/hashicorp/consul-template/watch      1.058s

@catsby
Copy link
Contributor Author

catsby commented Sep 20, 2019

cc @eikenb

@eikenb
Copy link
Contributor

eikenb commented Oct 18, 2019

Hey @catsby,

Thanks for the PR and sorry for the delay getting back to sooner. I'm working on some consul-connect integration right now but once done will be making another issue/PR pass through all my projects and will get to it then.

@catsby
Copy link
Contributor Author

catsby commented Dec 2, 2019

Hey @eikenb have you had a chance to review this?

@eikenb eikenb added this to the 0.23.1 milestone Dec 13, 2019
@eikenb
Copy link
Contributor

eikenb commented Dec 13, 2019

Thanks for your patience @catsby. I'm seeing if I can get a release out before the holidays and will take a look at this for inclusion.

@eikenb
Copy link
Contributor

eikenb commented Dec 16, 2019

@catsby Looks good. Thanks again!

@eikenb eikenb merged commit 1a531ed into hashicorp:master Dec 16, 2019
@catsby
Copy link
Contributor Author

catsby commented Dec 16, 2019

Thank you @eikenb !

@eikenb
Copy link
Contributor

eikenb commented Jan 7, 2020

@catsby .. You might have noticed I didn't make the pre-holidays release as I hoped. I was ready like the day before and thought it wasn't the best idea to release right before being away for a couple weeks. I'm back on it now though and should have it out soon.

@catsby
Copy link
Contributor Author

catsby commented Jan 7, 2020

No worries @eikenb , thanks for the follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove vault's grace period variables/logic
2 participants