Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grace use from code and config documentation #219

Closed
eikenb opened this issue Aug 28, 2019 · 0 comments · Fixed by #245
Closed

Remove grace use from code and config documentation #219

eikenb opened this issue Aug 28, 2019 · 0 comments · Fixed by #245
Assignees
@findkim
Labels
documentation

Comments

@eikenb
Copy link
Contributor

eikenb commented Aug 28, 2019

Vault deprecated (such that it is ignored) the use of grace in their API in version 0.5.0 (in 2016). I've spoken with the team and in their opinion it should be removed as they haven't seen any issues (internal or github) for a version near that old in a long time.

There are corresponding tickets in Consul-Template. One for docs and one for code (to fit its roadmap). I'll split this up here if necessary, but for now it's easier to just have 1 issue.

CT issues are: hashicorp/consul-template#1266 and hashicorp/consul-template#1268
eikenb added a commit that referenced this issue Sep 12, 2019
@eikenb
remove documentation about vault's grace parameter
b5e928a 
Grace was deprecated years ago (vault 0.5.0 in 2016) and has been
ignored since. Remove it from the documentation first to keep it from
confusing users. Swing back later to remove the dead code.

Issue #219 is about this and the code removal. This takes care of half
of it.
@findkim findkim self-assigned this Aug 18, 2020
This was referenced Aug 18, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findkim findkim

Labels
documentation
Projects
None yet
Milestone
No milestone
2 participants
@eikenb @findkim