remove stuff related to old build system #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clear out Makefile targets for release and Docker builds remove all old Docker configuration and support files
eikenb
force-pushed
the
remove-old-build-system
branch
from
ab9aea2 to
061ee6e
Compare
findkim
approved these changes
Jun 16, 2021
| # List of ldflags | ||
| LD_FLAGS ?= \ | ||
| -s \ | ||
| -w \ | ||
| -X ${PROJECT}/version.Name=${NAME} \ |
There was a problem hiding this comment.
makes sense to have consul-template hard-coded as the default value. Since it's a public variable, this options still stands for further customization for others 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clear out Makefile targets for release and Docker builds
remove all old Docker configuration and support files