[1.17.x] Move test setup out of subtest (#19754)

Move test setup out of subtest
hashicorp · Nov 29, 2023 · 1310981 · 1310981
1 parent 1549522
commit 1310981
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/internal/mesh/internal/controllers/sidecarproxy/controller_test.go b/internal/mesh/internal/controllers/sidecarproxy/controller_test.go
@@ -521,13 +521,11 @@ func (suite *controllerTestSuite) TestController() {
 		webComputedDestinations *pbresource.Resource
 	)
 
-	testutil.RunStep(suite.T(), "proxy state template generation", func(t *testing.T) {
-		// Check that proxy state template resource is generated for both the api and web workloads.
-		retry.Run(t, func(r *retry.R) {
-			suite.client.RequireResourceExists(r, apiProxyStateTemplateID)
-			webProxyStateTemplate = suite.client.RequireResourceExists(r, webProxyStateTemplateID)
-			apiProxyStateTemplate = suite.client.RequireResourceExists(r, apiProxyStateTemplateID)
-		})
+	// Check that proxy state template resource is generated for both the api and web workloads.
+	retry.Run(suite.T(), func(r *retry.R) {
+		suite.client.RequireResourceExists(r, apiProxyStateTemplateID)
+		webProxyStateTemplate = suite.client.RequireResourceExists(r, webProxyStateTemplateID)
+		apiProxyStateTemplate = suite.client.RequireResourceExists(r, apiProxyStateTemplateID)
 	})
 
 	// Write a default ComputedRoutes for api.