Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.17.x] Move test setup out of subtest #19754

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[1.17.x] Move test setup out of subtest #19754

merged 1 commit into from
Nov 29, 2023

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Nov 28, 2023 •
edited
Loading

Overview of commits

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@kisunji kisunji changed the title Move test setup out of subtest [1.17.x] Move test setup out of subtest Nov 28, 2023
@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Nov 28, 2023
@kisunji kisunji enabled auto-merge (squash) November 28, 2023 18:47
@kisunji kisunji mentioned this pull request Nov 28, 2023
Merged
4 tasks
@kisunji kisunji merged commit 1310981 into release/1.17.x Nov 29, 2023
96 of 97 checks passed
@kisunji kisunji deleted the kisunji/1.17-fix-controller-test branch November 29, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kisunji @zalimeni