Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-discover to fix broken dep tree #11064

Closed
wants to merge 2 commits into from

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Sep 16, 2021

Replaces #10898

jeffwidman and others added 2 commits August 23, 2021 11:45
The previous version of `go-discover` pulled in a broken version of
`tencentcloud-sdk-go`, resulting in anything that runs `go get -d`
downstream breaking... ie, a dep on hashicorp consul will break
Dependabot (among other things).

I already fixed it in `go-discover`, so this just pulls in the update.

More details in
hashicorp/go-discover@657e803
and hashicorp/go-discover#172.

Unfortunately, it looks like pulling this in also forces a couple of k8s
packages to get updated. I did not manually bump these... they were the
outcome of running `go mod tidy`.
@github-actions github-actions bot added the pr/dependencies PR specifically updates dependencies of project label Sep 16, 2021
@kisunji
Copy link
Contributor Author

kisunji commented Sep 16, 2021

Figured out how to push to a contributor's fork 😆

@kisunji kisunji closed this Sep 16, 2021
@rboyer rboyer deleted the bump-go-discover-past-broken-version branch November 1, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/dependencies PR specifically updates dependencies of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants