Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tencentcloud dependency seems to be gone #172

Closed
fagossa opened this issue May 17, 2021 · 2 comments · Fixed by #173
Closed

tencentcloud dependency seems to be gone #172

fagossa opened this issue May 17, 2021 · 2 comments · Fixed by #173

Comments

@fagossa
Copy link

fagossa commented May 17, 2021 •
edited
Loading

Hello people,

I've just realized that this project depends on an unexpected version of tencentcloud: https://github.com/hashicorp/go-discover/blob/master/go.mod#L33 :

github.com/tencentcloud/tencentcloud-sdk-go v3.0.83+incompatible

The tag v3.0.83 in their repo seems to be gone. I can still build locally because I imagine https://proxy.golang.org still has the cached version. However, it won't build using a configuration like this:

GOPROXY="direct"

So, I was wondering if you have plans for a new version of go-discover using an existing tag for tencentcloud?
In go-discover currently there are no tags (I know you are aware) so, a default v0.0.0 version is used in repos dependent on this one (eg, https://github.com/hashicorp/vault/blob/master/go.mod#L63 )

github.com/hashicorp/go-discover v0.0.0-20201029210230-738cb3105cd0

Edit:
go-kms-wrapping seems to have the same problem. I also created an issue over there.

Thanks a lot
@jeffwidman
Copy link
Contributor

Hitting the same problem, this is causing Dependabot runs to fail against multiple repo's due to the broken dep tree.

@fagossa fagossa mentioned this issue May 18, 2021
Closed
This was referenced May 18, 2021
Closed
Merged
@ncode
Copy link

ncode commented Jun 1, 2021 •
edited
Loading

Hello,

I'm not able to build the containerd nomad driver, due to this dependency issue:

/usr/bin/go build -o containerd-driver .
go: github.com/hashicorp/[email protected] requires
        github.com/hashicorp/[email protected] requires
        github.com/tencentcloud/[email protected]+incompatible: reading github.com/tencentcloud/tencentcloud-sdk-go/go.mod at revision v3.0.83: unknown revision v3.0.83

@ncode ncode mentioned this issue Jun 1, 2021
Closed
@qbiqing qbiqing mentioned this issue Aug 16, 2021
Merged
This was referenced Aug 23, 2021
Merged
Merged
ncabatoff pushed a commit to hashicorp/vault that referenced this issue Aug 24, 2021
@jeffwidman
Bump go-discover to fix broken dep (#12404)
ce442ad 
The previous version of `go-discover` pulled in a broken version of
`tencentcloud-sdk-go`, resulting in anything that runs `go get -d`
downstream breaking... ie, a dep on hashicorp vault will break
Dependabot (among other things).

I already fixed it in `go-discover`, so this just pulls in the update.

More details in
hashicorp/go-discover@657e803
and hashicorp/go-discover#172.
@lwithers lwithers mentioned this issue Oct 5, 2021
Closed
2 tasks
@spacelatte spacelatte mentioned this issue Dec 3, 2021
Open
@jdoss jdoss mentioned this issue Feb 11, 2022
Merged
acaloiaro pushed a commit to acaloiaro/go-discover that referenced this issue Nov 24, 2022
@jeffwidman @acaloiaro
Update tencent version
565b2c5 
Tencent pulled the previous tag of their API and switched to `v1`
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90

As a result, currently `go get -d` is complaining in downstream repos,
breaking Dependabot (among other things).

So this fixes that.

Fix hashicorp#172.
acaloiaro pushed a commit to acaloiaro/go-discover that referenced this issue Nov 24, 2022
@jeffwidman @acaloiaro
Update tencent version
59f9cc0 
Tencent pulled the previous tag of their API and switched to `v1`
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90

As a result, currently `go get -d` is complaining in downstream repos,
breaking Dependabot (among other things).

So this fixes that.

Fix hashicorp#172.
@ttys3 ttys3 mentioned this issue Jun 15, 2023
Closed
1 task
peczenyj pushed a commit to peczenyj/go-discover that referenced this issue Dec 21, 2023
@jeffwidman @peczenyj
parent 738cb31
a49c317 
author Jeff Widman <[email protected]> 1621366525 -0700
committer Tiago Peczenyj <[email protected]> 1703171978 +0100

Update tencent version

Tencent pulled the previous tag of their API and switched to `v1`
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90

As a result, currently `go get -d` is complaining in downstream repos,
breaking Dependabot (among other things).

So this fixes that.

Fix hashicorp#172.

Update CI badge to CircleCI

The old badge was travis, and we have not used travis in some time.

update dependency

fix incompatibity issue hashicorp#183

Revert "fix incompatibity issue hashicorp#183"

This reverts commit 986207c.

Revert "update dependency"

This reverts commit bc42ce5.

update dependency github.com/denverdino/aliyungo

fix incompatibity issue hashicorp#183

go mod tidy

Add AWS SessionToken Support (hashicorp#189)

* add support for SessionToken in AWS credential resolver

* add AWS AssumeRole configuration to AWS tests

Fix "Config options" links

Apply suggestions from code review

Co-authored-by: Blake Covarrubias <[email protected]>

deps: bump Azure/go-autorest to remove transitive jwt-go dependency with known vulnerability (hashicorp#174)

update dependency github.com/denverdino/aliyungo

Add AWS SessionToken Support (hashicorp#189)

* add support for SessionToken in AWS credential resolver

* add AWS AssumeRole configuration to AWS tests

Fix "Config options" links

Apply suggestions from code review

Co-authored-by: Blake Covarrubias <[email protected]>

Add AWS endpoint definition as an option (hashicorp#194)

Signed-off-by: obeyler <[email protected]>

Feature/aws ecs support (hashicorp#197)

* Add service argument to aws provider, where service can be either ec2 or ecs (defaulting to ec2)
* Add optional ecs_cluster and ecs_family arguments

Update tencentcloud-sdk-go modules

Dependencies are available as individual go modules now.

[COMPLIANCE] Update MPL 2.0 LICENSE

Adding workflow .github/actions/acctest/action.yml
.github/actions/tf-install/action.yml
.github/workflows/acceptance.yml

SHA-pin all 3rd-party actions

Restrict workflow permissions

Add actionslint

Add dependabot

Add CODEOWNERS

Remove CircleCI configuration

Remove unused local actions

Update migration

enable scleway acceptance test

add success job

add success job

fix copy pasta

Result of tsccr-helper -pin-all-workflows .

Fix CVEs

Need at least go 1.16 for the golang.org/x/net fixes

Update github action to use go 1.16

Some dependencies needed 1.17

Set miekg/dns to 1.1.50

Result of tsccr-helper -log-level=info -pin-all-workflows .

Update README.md

Update README.md

Update README.md

Update README.md

update vendor github.com/denverdino/aliyungo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tencent version
3 participants
@ncode @jeffwidman @fagossa