Support vault namespaces in connect CA #12735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
theme/connect
markan
added
the
pr/no-changelog
markan
force-pushed
the
ma/vault-namespace-intermediate-provider
branch
from
98526ff to
77edda8
Compare
markan
force-pushed
the
ma/vault-namespace-intermediate-provider
branch
from
77edda8 to
017477e
Compare
markan
force-pushed
the
ma/vault-namespace-intermediate-provider
branch
from
253c54e to
5a095e5
Compare
kyhavlov
approved these changes
Apr 13, 2022
| @@ -852,3 +852,34 @@ func vaultProviderConfig(t *testing.T, addr, token string, rawConf map[string]in | |||
|
|
|||
| return cfg | |||
| } | |||
|
|
|||
| func TestVaultProvider_potentialMountPaths(t *testing.T) { | |||
|
|
|||
There was a problem hiding this comment.
I think this is a leftover extra whitespace line
| @@ -284,7 +286,8 @@ func (v *VaultProvider) GenerateRoot() (RootResult, error) { | |||
| rootPEM, err := v.getCA(v.config.RootPKIPath) | |||
| switch err { | |||
| case ErrBackendNotMounted: | |||
| err := v.client.Sys().Mount(v.config.RootPKIPath, &vaultapi.MountInput{ | |||
|
|
|||
There was a problem hiding this comment.
Leftover extra whitespace line
Follow on to some missed items from #12655 From an internal ticket "Support standard "Vault namespace in the path" semantics for Connect Vault CA Provider" Vault allows the namespace to be specified as a prefix in the path of a PKI definition, but our usage of the Vault API includes calls that don't support a namespaced key. In particular the sys.* family of calls simply appends the key, instead of prefixing the namespace in front of the path. Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
markan
force-pushed
the
ma/vault-namespace-intermediate-provider
branch
from
b93c96e to
0ba6baf
Compare
jkirschner-hashicorp
added
the
pr/do-not-merge
|
Temporarily marking |
|
Closing this PR in favor of a new approach in PR #12904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to some missed items from #12655
From an internal ticket "Support standard "Vault namespace in the
path" semantics for Connect Vault CA Provider"
Vault allows the namespace to be specified as a prefix in the path of
a PKI definition, but our usage of the Vault API includes calls that
don't support a namespaced key. In particular the sys.* family of
calls simply appends the key, instead of prefixing the namespace in
front of the path.
Signed-off-by: Mark Anderson [email protected]