Backport of auto-config: relax node name validation for JWT authorization into release/1.14.x #15372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/auto-config-node-validation/firmly-desired-wombat
branch
from
c96a161 to
3be9472
Compare
hc-github-team-consul-core
force-pushed
the
backport/auto-config-node-validation/firmly-desired-wombat
branch
from
ca2b4b8 to
58e18de
Compare
hc-github-team-consul-core
deleted the
backport/auto-config-node-validation/firmly-desired-wombat
branch
github-actions
bot
added
theme/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15370 to be assessed for backporting due to the inclusion of the label backport/1.14.
The below text is copied from the body of the original PR.
This changes the JWT authorization logic to allow all non-whitespace, non-quote characters when validating node names. Consul had previously allowed these characters in node names, until this validation was added to fix a security vulnerability with whitespace/quotes being passed to the
bexprlibrary. This unintentionally broke node names with characters like.which aren't related to this vulnerability. This PR also adds a warning on agent startup if an invalid character is present in the node name (at some point we can consider changing this to a hard error).Overview of commits