[NET-6426] Add gateway proxy controller that generates empty proxy state template #19901
Conversation
nathancoleman
added
theme/mesh-gw
nathancoleman
force-pushed
the
gatewayproxy-controller
branch
from
69b0ef6 to
45e54ff
Compare
nathancoleman
changed the title
nathancoleman
changed the title
This cheats and looks up the MeshGateway directly. In the future, we will need a Workload => xGateway mapper
nathancoleman
force-pushed
the
gatewayproxy-controller
branch
from
efc4291 to
e6ba50b
Compare
nathancoleman
requested review from
jm96441n,
a team and
sarahalsmiller
and removed request for
a team
| @@ -9,6 +9,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/hashicorp/go-multierror" | |||
| "golang.org/x/exp/maps" | |||
There was a problem hiding this comment.
kinda off topic but are we planning to move to go 1.21 soon? the maps and slices package are part of the std lib as of that release
There was a problem hiding this comment.
No idea -- I assume there's a standard cadence that different teams follow @ Hashi
| // an owner reference pointing to the corresponding pbmesh.MeshGateway, deletion is | ||
| // left to the garbage collector. | ||
| func (r *reconciler) Reconcile(ctx context.Context, rt controller.Runtime, req controller.Request) error { | ||
| rt.Logger = rt.Logger.With("resource-id", req.ID) |
There was a problem hiding this comment.
is it possible we'll ever be running this reconciler in more than one thread? if so I don't think this assignment is threadsafe and we might want to use a local var instead
There was a problem hiding this comment.
You are correct. Since virtually every v2 resource controller that exists today uses this pattern, I'm fine leaving it and knowing that any change in the future would have to update all the other controllers as well. Thoughts?
and on and on...
There was a problem hiding this comment.
All controllers today operate as a single thread. Each dependency mapper IIRC runs in its own goroutine though.
| @@ -41,6 +41,7 @@ flowchart TD | |||
| mesh/v2beta1/proxyconfiguration | |||
| mesh/v2beta1/proxystatetemplate --> auth/v2beta1/computedtrafficpermissions | |||
| mesh/v2beta1/proxystatetemplate --> catalog/v2beta1/service | |||
| mesh/v2beta1/proxystatetemplate --> catalog/v2beta1/serviceendpoints | |||
There was a problem hiding this comment.
This graph is generated by the golden file test below
| ) | ||
|
|
||
| // ControllerName is the name for this controller. It's used for logging or status keys. | ||
| const ControllerName = "consul.io/gateway-proxy-controller" |
There was a problem hiding this comment.
for consistency with other name changes across consul recently
| const ControllerName = "consul.io/gateway-proxy-controller" | |
| const ControllerName = "consul.io/gateway-proxy" |
internal/mesh/internal/controllers/gatewayproxy/fetcher/data_fetcher.go
Outdated
Show resolved
Hide resolved
internal/mesh/internal/controllers/gatewayproxy/fetcher/data_fetcher.go
Outdated
Show resolved
Hide resolved
nathancoleman
changed the title
Description
This PR creates the
gatewayproxy.Controller, analogous to thesidecarproxy.Controllerbut designed to createdProxyStateTemplate(PST) resources for xGateways. It relies ongateway-kindbeing set in the metadata of theWorkloadthat the PST is being created for.#19902 introduced logic to have the sidecar proxy controller skip workloads with this piece of metadata so that the two controllers will not be fighting to write the same PST.
Testing & Reproduction steps
Links
PR Checklist