-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update changelog and website checks #9781
Conversation
🤔 Double check that this PR does not require a changelog entry in the |
This will go away after this gets merged, it's running the old check in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One question, but not blocking, probably just a minor optimization.
with: | ||
ref: ${{ github.event.pull_request.head.sha }} | ||
fetch-depth: 0 # by default the checkout action doesn't checkout all branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we omit this now that it uses on: pull_request
instead of target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can test but I don't think so, we still need to checkout all branches to compare the HEAD to the base ref (which wouldn't be checked out if we just checkout HEAD).
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/333004. |
This PR splits out the
website/
check to only run on PRopened
while the changelog check runs onopened
,synchronize
(new commits) andlabeled
and also changes it to a status check that fails when there is nopr/no-changelog
label applied nor is there a.changelog/$pr_number.txt
file.I also changed the
on
trigger to bepull_request
for the changelog check because it no longer needs a token secret to post to the PR so it doesn't need to only run onpull_request_target