Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make changelog-checker only validate PR number against main base #10844

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Aug 12, 2021

Intent of this change is to avoid spurious changelog-checker failures on manual backport PRs, where cherry-picking the changelog entry from the original commit will intentionally not match the PR number of the backport (matching the original change instead).

My bash might need some revisions to make sure the logic is correct and syntax is valid.

@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Aug 12, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 12, 2021 22:10 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 12, 2021 22:10 Inactive
@mikemorris
Copy link
Contributor Author

mikemorris commented Aug 13, 2021

@alvin-huang Any idea why this check is now just failing with exit code 1 instead of failing and commenting on the PR? I didn't change much, but is there a different way these should be written now (like with https://github.com/actions/github-script#comment-on-an-issue?) or is this an effect of editing this file in the PR?

Edit: Check was failing on invalid bash syntax which is now fixed, PR comment had been intentionally removed in #9781 to prefer just using a status check instead.

@mikemorris mikemorris requested a review from alvin-huang August 13, 2021 15:08
@vercel vercel bot temporarily deployed to Preview – consul August 13, 2021 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 13, 2021 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 16, 2021 15:21 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2021 15:21 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mikemorris mikemorris force-pushed the github/changelog-checker-pr-number branch from 8f7248d to d29751b Compare August 16, 2021 18:31
@vercel vercel bot temporarily deployed to Preview – consul August 16, 2021 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2021 18:31 Inactive
@mikemorris mikemorris changed the title github: make changelog-checker only validate PR number against main base ci: make changelog-checker only validate PR number against main base Aug 16, 2021
@vercel vercel bot temporarily deployed to Preview – consul August 16, 2021 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2021 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 16, 2021 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2021 19:11 Inactive
@mikemorris mikemorris requested a review from a team August 16, 2021 19:20
@mikemorris mikemorris merged commit 2a98ed5 into main Aug 16, 2021
@mikemorris mikemorris deleted the github/changelog-checker-pr-number branch August 16, 2021 19:40
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/428417.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 2a98ed5 onto release/1.10.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants