-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make changelog-checker only validate PR number against main base #10844
Conversation
@alvin-huang Any idea why this check is now just failing with exit code Edit: Check was failing on invalid bash syntax which is now fixed, PR comment had been intentionally removed in #9781 to prefer just using a status check instead. |
8f7248d
to
d29751b
Compare
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/428417. |
🍒✅ Cherry pick of commit 2a98ed5 onto |
Intent of this change is to avoid spurious changelog-checker failures on manual backport PRs, where cherry-picking the changelog entry from the original commit will intentionally not match the PR number of the backport (matching the original change instead).
My bash might need some revisions to make sure the logic is correct and syntax is valid.