Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nia/docs 0.1.0 beta #9803

Merged
merged 28 commits into from
Feb 25, 2021
Merged

nia/docs 0.1.0 beta #9803

merged 28 commits into from
Feb 25, 2021

Conversation

findkim
Copy link
Contributor

@findkim findkim commented Feb 22, 2021

No description provided.

@vercel
Copy link

vercel bot commented Feb 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

consul-ui-staging – ./ui

🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/C9cAA5XptNd9rcL2DTBmkXYE6Jat
✅ Preview: Canceled

[Deployment for b56913e canceled]

@github-actions github-actions bot added theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation type/docs Documentation needs to be created/updated/clarified labels Feb 22, 2021
@hashicorp-ci
Copy link
Contributor

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@picatz
Replace tech preview with beta in sidebar title
7f01df5
@picatz
Update overview section to reflect other NIA docs better
9e2aee6
@picatz
Simplify start of the personas sections
01b4c54
@picatz
Update the NIA daemon wording usage
5fdf053 
This document used the "NIA daemon", which essentially refers to the consul-terraform-sync binary running in daemon mode.

I think it makes sense to use "`consul-terraform-sync`", "NIA daemon", and "daemon" interchangeably, depending on context.
@picatz
Drop the arguably unnecessary product reference
43145f5 
I really love Nomad, and this might still be nice to have... but also not totally needed in this document.
@picatz
Favor full "and" instead of ampersand
8a33858
@picatz
Update usage of catalog in the overview
13c6060
@picatz
Remove accidental brackets
2c0969d
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 23, 2021 20:57 Inactive
@findkim findkim force-pushed the nia/docs-0.1.0-beta branch from b56913e to 61e33b1 Compare February 23, 2021 21:47
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 23, 2021 21:47 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 23, 2021 22:23 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 23, 2021 23:10 Inactive
@lornasong
docs/nia: reorganize cli page into multiple pages
139a8e6 
Rename existing cli page as 'overview' and move it into a cli directory
lornasong and others added 3 commits February 25, 2021 10:56
@lornasong
docs/nia: new api error object
dd60738
@lornasong
docs/nia: update status api
5e0f5df 
 - Reorganize Overall Status response to return status information as a sub-
 structure of task_summary
 - Add new 'unknown' status value to Overall Status response
 - Add new enabled information as a substructure of task_summary
 - Add new enabled field to Task Status
@eikenb
add note about HTTP/2 support and setup
8f4ea95 
Also expand the "Run an Agent" section in requirements to mention the
HTTP/2 fix.
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 25, 2021 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 25, 2021 18:25 Inactive
@findkim
docs/nia: reorganize tf module details to top level nav (#9830)
6ca6f14 
* docs/nia: reorganize tf module details to top level nav
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 25, 2021 19:25 Inactive
@findkim findkim marked this pull request as ready for review February 25, 2021 21:55
@findkim findkim requested a review from a team February 25, 2021 21:55
lornasong
lornasong approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs that make this branch are separately approved. From a skim, this looks good!

@findkim findkim merged commit b678eab into master Feb 25, 2021
@findkim findkim deleted the nia/docs-0.1.0-beta branch February 25, 2021 22:48
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/332627.

@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit b678eab onto stable-website failed! Build Log

@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit b678eab onto release/1.9.x failed! Build Log

@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/332657.

@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit b678eab onto stable-website failed! Build Log

@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit b678eab onto release/1.9.x failed! Build Log

findkim added a commit that referenced this pull request Feb 25, 2021
@findkim @picatz
@lornasong @eikenb
nia/docs 0.1.0 beta (#9803)
7884705 
nia/docs 0.1.0-beta

Co-authored-by: Kent 'picat' Gruber <[email protected]>
Co-authored-by: Lorna Song <[email protected]>
Co-authored-by: John Eikenberry <[email protected]>
findkim added a commit to findkim/consul that referenced this pull request Feb 25, 2021
@findkim @picatz
@lornasong @eikenb
nia/docs 0.1.0 beta (hashicorp#9803)
e0517da 
nia/docs 0.1.0-beta

Co-authored-by: Kent 'picat' Gruber <[email protected]>
Co-authored-by: Lorna Song <[email protected]>
Co-authored-by: John Eikenberry <[email protected]>
@findkim findkim mentioned this pull request Feb 25, 2021
Merged
findkim added a commit that referenced this pull request Feb 25, 2021
@findkim @picatz
@lornasong @eikenb
nia/docs 0.1.0 beta (#9803) (#9834)
07bf4ec 
nia/docs 0.1.0-beta

Co-authored-by: Kent 'picat' Gruber <[email protected]>
Co-authored-by: Lorna Song <[email protected]>
Co-authored-by: John Eikenberry <[email protected]>
findkim added a commit that referenced this pull request Feb 25, 2021
@findkim @picatz
@lornasong @eikenb
nia/docs 0.1.0 beta (#9803) (#9834)
8e5fc47 
nia/docs 0.1.0-beta

Co-authored-by: Kent 'picat' Gruber <[email protected]>
Co-authored-by: Lorna Song <[email protected]>
Co-authored-by: John Eikenberry <[email protected]>
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
dizzyup pushed a commit that referenced this pull request Apr 21, 2021
@findkim @picatz
@lornasong @eikenb @dizzyup
nia/docs 0.1.0 beta (#9803) (#9834)
c761a18 
nia/docs 0.1.0-beta

Co-authored-by: Kent 'picat' Gruber <[email protected]>
Co-authored-by: Lorna Song <[email protected]>
Co-authored-by: John Eikenberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornasong lornasong lornasong approved these changes

Assignees
No one assigned
Labels
theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@findkim @hashicorp-ci @lornasong @picatz @eikenb