Update CT dep and rm vault grace #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vault grace has been removed from Consul Template in v0.24.0. Updating the CT dependency required removing references of vault grace as well.
This was referenced Aug 18, 2020
eikenb
approved these changes
Aug 19, 2020
|
👍 I had considered splitting it up into different commits but ended up preferring the commit to build properly instead. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault grace has been removed from Consul Template in v0.24.0. Updating the CT dependency required removing references of vault grace as well, I didn't find any documentation references so none are in the diffs. There are a few other attributes that had changed their names as well, like
NametoSyslogNameandAllowlistDeprecatedResolves #219