Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tencent version #173

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Update tencent version #173

merged 1 commit into from
Aug 17, 2021

Conversation

jeffwidman
Copy link
Contributor

Tencent pulled the previous tag of their API and switched to v1
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90

As a result, currently go get -d is complaining in downstream repos,
breaking Dependabot (among other things).

So this fixes that.

Fix #172.

Tencent pulled the previous tag of their API and switched to `v1`
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90

As a result, currently `go get -d` is complaining in downstream repos,
breaking Dependabot (among other things).

So this fixes that.

Fix #172.
@hashicorp-cla
Copy link

hashicorp-cla commented May 18, 2021

CLA assistant check
All committers have signed the CLA.

@jeffwidman
Copy link
Contributor Author

jeffwidman commented May 21, 2021

nudge @dnephin @RussellRollins any chance you could look at this? Our downstream Dependabot builds are currently broken and this PR (plus hashicorp/go-kms-wrapping#32) would fix it...

@RussellRollins
Copy link
Contributor

Hi @jeffwidman.

I see a few differences locally when checking out your fork and running go mod tidy. Do you think you could run tidy and commit the changes?

@jeffwidman
Copy link
Contributor Author

My apologies for the delay, we had a new baby, so I'm just emerging from the fog.

@RussellRollins I ran go mod tidy when I put this up, and I just re-ran it to be sure, and I don't see any updates... What version of go are you using? I ran it originally with go 1.16.3 and just re-ran it with the just released 1.16.5 and neither one mutates go.sum at all for me...

Feel free to add a commit onto this PR with the changes that you're seeing in order to unblock the merge, although for safety you'd probably want to understand why you're seeing changes that I'm not.

@jeffwidman
Copy link
Contributor Author

gentle nudge @RussellRollins

let me know if anything I can do to move this forward...

@RussellRollins
Copy link
Contributor

@jeffwidman I am no longer able to reproduce those differences, so clearly an error between my keyboard and my chair, sorry about that, and thanks for confirming you already tidy'd.

Unfortunately, in terms of getting this merged, we really will need the approval and assistance of someone on @hashicorp/consul. I really don't know much about go-discover, I have only interacted with it in terms of working on HashiCorp's CI system.

I know the delay here has been frustrating. One workaround you might attempt in the short term, if you are only dependent on tencent as a transitive dependency is adding a replace directive to your go.mod file. Something like:

replace github.com/tencentcloud/tencentcloud-sdk-go v3.0.83+incompatible => github.com/tencentcloud/tencentcloud-sdk-go v1.0.162

@jeffwidman
Copy link
Contributor Author

Thanks @RussellRollins.

Any chance you could nudge someone on @hashicorp/consul team to look at this?

It'd be nice to get this resolved so we don't have to do manual workarounds like // indirect pins or using replace.

@jeffwidman
Copy link
Contributor Author

@jefferai @RussellRollins any chance one of you could nudge someone on @hashicorp/consul team to take a look at this PR? I come back from paternity leave to find it's still broken 😢 .

@jeffwidman
Copy link
Contributor Author

jeffwidman commented Aug 4, 2021

@eculver @dnephin this PR is simple, but needs review/input from the consul team, can you take a look?

@qbiqing
Copy link

qbiqing commented Aug 16, 2021

Any update for this? Would be really useful. My current workaround is adding https://proxy.golang.org to GOPROXY.

@dhiaayachi
Copy link
Contributor

Thank you for this contribution @jeffwidman

@dhiaayachi dhiaayachi merged commit fccf997 into hashicorp:master Aug 17, 2021
@jeffwidman
Copy link
Contributor Author

Thanks for merging @dhiaayachi

@jeffwidman jeffwidman deleted the switch-to-actual-tencent-version branch August 18, 2021 04:17
@jeffwidman
Copy link
Contributor Author

jeffwidman commented Aug 23, 2021

I opened several PR's to update downstream repos that depend on this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tencentcloud dependency seems to be gone
5 participants