-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tencent version #173
Update tencent version #173
Conversation
Tencent pulled the previous tag of their API and switched to `v1` starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90 As a result, currently `go get -d` is complaining in downstream repos, breaking Dependabot (among other things). So this fixes that. Fix #172.
nudge @dnephin @RussellRollins any chance you could look at this? Our downstream Dependabot builds are currently broken and this PR (plus hashicorp/go-kms-wrapping#32) would fix it... |
Hi @jeffwidman. I see a few differences locally when checking out your fork and running |
My apologies for the delay, we had a new baby, so I'm just emerging from the fog. @RussellRollins I ran Feel free to add a commit onto this PR with the changes that you're seeing in order to unblock the merge, although for safety you'd probably want to understand why you're seeing changes that I'm not. |
gentle nudge @RussellRollins let me know if anything I can do to move this forward... |
@jeffwidman I am no longer able to reproduce those differences, so clearly an error between my keyboard and my chair, sorry about that, and thanks for confirming you already tidy'd. Unfortunately, in terms of getting this merged, we really will need the approval and assistance of someone on @hashicorp/consul. I really don't know much about I know the delay here has been frustrating. One workaround you might attempt in the short term, if you are only dependent on tencent as a transitive dependency is adding a replace directive to your
|
Thanks @RussellRollins. Any chance you could nudge someone on @hashicorp/consul team to look at this? It'd be nice to get this resolved so we don't have to do manual workarounds like |
@jefferai @RussellRollins any chance one of you could nudge someone on @hashicorp/consul team to take a look at this PR? I come back from paternity leave to find it's still broken 😢 . |
Any update for this? Would be really useful. My current workaround is adding |
Thank you for this contribution @jeffwidman |
Thanks for merging @dhiaayachi |
I opened several PR's to update downstream repos that depend on this: |
Tencent pulled the previous tag of their API and switched to
v1
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90
As a result, currently
go get -d
is complaining in downstream repos,breaking Dependabot (among other things).
So this fixes that.
Fix #172.