Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for configuring operations #84

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Adding support for configuring operations #84

merged 3 commits into from
Sep 27, 2019

Conversation

sudomateo
Copy link
Contributor

@sudomateo sudomateo commented Sep 14, 2019 •
edited
Loading

Attempting to add the ability to manage execution mode via the SDK. Looking for some feedback and also help with adding this to tests.

@sudomateo sudomateo mentioned this pull request Sep 14, 2019
Merged
svanharmelen
svanharmelen reviewed Sep 14, 2019
View reviewed changes
Copy link
Contributor

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it would be nice to update or add at least one test for this to make sure that it works as expected.

@sudomateo
Copy link
Contributor Author

Thanks for the feedback. I added this to existing tests, but I didn't write a new test as I would need some more guidance there.

@svanharmelen
Copy link
Contributor

When/if all the checks pass (I can no longer test this easily myself), this should be good to go 👍

alisdair
alisdair approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, and this looks good to me 👍

@sudomateo sudomateo marked this pull request as ready for review September 27, 2019 17:06
@sudomateo sudomateo merged commit 0289275 into master Sep 27, 2019
@sudomateo sudomateo deleted the feature/workspace-operations branch September 27, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanharmelen svanharmelen svanharmelen left review comments

@alisdair alisdair alisdair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudomateo @svanharmelen @alisdair