Adding support to configure execution mode #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
There was a problem hiding this comment.
I think this looks good 👍 It probably only need some (updated) tests and maybe we should think for a minute about the name remote_execution.
While I very much agree that this name is more descriptive then just operation, it's about the only place were we would have a different name in the TF provider then what is used in the API. Not a problem, but something to make a conscious decision about.
Renamed to operations Alphabetized new item in the schema Initial pass at adding to tests
|
Thank you again for the feedback. I pushed some changes to implement the changes. I'm okay with renaming this |
alisdair
approved these changes
Sep 25, 2019
|
Fixes #87 |
sudomateo
force-pushed
the
feature/workspace-operations
branch
from
3068a13 to
7d09326
Compare
alisdair
added a commit
that referenced
this pull request
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to add the ability to manage execution mode via the SDK. Looking for some feedback and also help with adding this to tests.
Requires hashicorp/go-tfe#84 to be merged first.