Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreRelease comparison bug? #61

Open
vsimon opened this issue Sep 11, 2019 · 1 comment
Open

PreRelease comparison bug? #61

vsimon opened this issue Sep 11, 2019 · 1 comment

Comments

@vsimon
Copy link
Contributor

vsimon commented Sep 11, 2019

In looking at the ComparePreReleases test cases...

func TestComparePreReleases(t *testing.T) {
	cases := []struct {
		v1       string
		v2       string
		expected int
	}{
...
            {"5.4-alpha", "5.4-alpha.beta", 1},
}

I'm noticing that 5.4-alpha is larger (has a higher precedence) than 5.4-alpha.beta. However when reading over the precedence rules of pre-releases in semver (https://semver.org/#spec-item-11)

A larger set of pre-release fields has a higher precedence than a smaller set, 
if all of the preceding identifiers are equal. 
Example: 1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-alpha.beta < 1.0.0-beta < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1 < 1.0.0.

In this test case, all the preceding identifiers are equal - "5.4" - and the larger set "alpha.beta" has a lower precedence than the smaller set "alpha". Shouldn't it have a higher precedence?
@vsimon
Copy link
Contributor Author

vsimon commented Sep 11, 2019

I'd be willing to create a PR maybe if this is a problem.

vsimon pushed a commit to vsimon/go-version that referenced this issue Sep 11, 2019
Fix comparison bug when comparing non-numeric prereleases
4fb518e 
Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal.

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a few additional test cases.
@vsimon vsimon mentioned this issue Sep 11, 2019
Closed
vsimon pushed a commit to vsimon/go-version that referenced this issue Oct 4, 2019
Fix comparison bug when comparing non-numeric prereleases
0d929e6 
Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal.

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a few additional test cases.
vsimon pushed a commit to vsimon/go-version that referenced this issue Oct 8, 2019
Fix comparison bug when comparing non-numeric prereleases
66b6799 
Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal.

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a few additional test cases.
vsimon pushed a commit to vsimon/go-version that referenced this issue Oct 8, 2019
Fix comparison bug when comparing non-numeric prereleases
2714aa2 
Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal.

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a few additional test cases.
vsimon pushed a commit to vsimon/go-version that referenced this issue Oct 8, 2019
Fix comparison bug when comparing non-numeric prereleases
365f18d 
Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal.

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a few additional test cases.
vsimon pushed a commit to vsimon/go-version that referenced this issue Oct 8, 2019
Fix comparison bug when comparing non-numeric prereleases
0dcf719 
Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal. Source: https://semver.org/#spec-item-11

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a round out some additional test cases.
@vsimon vsimon mentioned this issue Oct 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vsimon