Fix comparison bug when comparing non-numeric prereleases #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: hashicorp#61 This fixes a bug when comparing non-numeric prereleases of different set sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta because a larger set of pre-release fields should have a higher precedence than a smaller set if all of the preceding identifiers are equal. When considering prerelease parts that are empty, use the other to decide regardless if it is numeric or not. If our self part is empty then the other part must be the larger set. If the other part is empty then the self part must be the larger set. Also fix and add a few additional test cases.
vsimon
force-pushed
the
prerelease-comp
branch
from
4fb518e to
0d929e6
Compare
|
friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal. Source: https://semver.org/#spec-item-11
When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.
Also fix and add a round out some additional test cases.