dynamic host volumes: send register to client for fingerprint #24802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
12bac9b to
4e59820
Compare
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
4e59820 to
21158f4
Compare
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
21158f4 to
fa258c8
Compare
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
fa258c8 to
c8bfea0
Compare
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
c8bfea0 to
a10b429
Compare
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
a10b429 to
6ac78c6
Compare
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
6ac78c6 to
64726b5
Compare
When we register a volume without a plugin, we need to send a client RPC so that the node fingerprint can be updated. The registered volume also needs to be written to client state so that we can restore the fingerprint after a restart.
Co-authored-by: Daniel Bennett <[email protected]>
tgross
force-pushed
the
dhv-register-client-rpc
branch
from
ba35c05 to
252f99d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we register a volume without a plugin, we need to send a client RPC so that the node fingerprint can be updated. The registered volume also needs to be written to client state so that we can restore the fingerprint after a restart.