-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental Prefill Required Fields feature #657
Conversation
432dce3
to
4ee3778
Compare
aa52ea0
to
a849645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I reckon you'll want to re-pin to the merged revision though, once hashicorp/hcl-lang#89 is merged.
Oh, one last thing - I think we should also document this new experiment here: https://github.com/hashicorp/terraform-ls/blob/main/docs/SETTINGS.md#experimentalfeatures It doesn't have to be part of this PR, but we should do it before releasing it, so that we can also link to it from the changelog. |
a849645
to
bee7ef8
Compare
Updated the pin for hcl-lang, and added detail for the new setting to SETTINGS.md |
bee7ef8
to
ce6ea1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a new experimental setting for prefilling required fields as blocks are completed from intellisense. For example, completing a resource provider will fill in the required attributes automatically.
5df5b84
to
cedf396
Compare
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This adds a new experimental setting for prefilling required fields as blocks are completed from intellisense. For example, completing a resource provider will fill in the required attributes automatically.
Needs hashicorp/hcl-lang#89