Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Fix hardcoded ARN (Glue*) #15740

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 20, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15662

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud) (no regressions):

--- PASS: TestAccAWSGlueJob_MaxCapacity (58.71s)
--- FAIL: TestAccAWSGlueJob_nonOverridableArguments (66.57s)
--- PASS: TestAccAWSGlueJob_disappears (21.47s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (87.18s)
--- PASS: TestAccAWSGlueMLTransform_basic (20.64s)
--- PASS: TestAccAWSGlueJob_PythonShell (103.97s)
--- PASS: TestAccAWSGlueJob_Command (118.09s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (120.60s)
--- PASS: TestAccAWSGlueJob_MaxRetries (124.94s)
--- PASS: TestAccAWSGlueJob_GlueVersion (140.29s)
--- PASS: TestAccAWSGlueJob_WorkerType (140.70s)
--- PASS: TestAccAWSGlueJob_basic (144.75s)
--- PASS: TestAccAWSGlueJob_Description (159.32s)
--- PASS: TestAccAWSGlueMLTransform_description (77.72s)
--- PASS: TestAccAWSGlueJob_Tags (166.81s)
--- PASS: TestAccAWSGlueMLTransform_glueVersion (80.69s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (170.81s)
--- PASS: TestAccAWSGlueMLTransform_disappears (42.52s)
--- PASS: TestAccAWSGlueMLTransform_typeFindMatchesFull (106.37s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (189.17s)
--- PASS: TestAccAWSGlueJob_Timeout (189.69s)
--- PASS: TestAccAWSGlueMLTransform_maxRetries (86.59s)
--- PASS: TestAccAWSGlueMLTransform_timeout (74.75s)
--- PASS: TestAccAWSGlueMLTransform_workerType (71.75s)
--- PASS: TestAccAWSGlueMLTransform_maxCapacity (60.46s)
--- PASS: TestAccAWSGlueMLTransform_tags (84.19s)

***Failure is preexisting & unrelated, tracked in separate issue #15764

Output from acceptance testing (commercial):

--- PASS: TestAccAWSGlueJob_disappears (76.33s)
--- PASS: TestAccAWSGlueJob_basic (81.07s)
--- PASS: TestAccAWSGlueMLTransform_basic (86.66s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (142.00s)
--- PASS: TestAccAWSGlueMLTransform_glueVersion (144.61s)
--- PASS: TestAccAWSGlueMLTransform_description (144.73s)
--- PASS: TestAccAWSGlueJob_Timeout (145.16s)
--- PASS: TestAccAWSGlueJob_Description (145.54s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (146.29s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (147.95s)
--- PASS: TestAccAWSGlueJob_MaxRetries (148.54s)
--- PASS: TestAccAWSGlueJob_nonOverridableArguments (149.37s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (149.47s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (150.25s)
--- PASS: TestAccAWSGlueJob_Command (150.31s)
--- PASS: TestAccAWSGlueMLTransform_typeFindMatchesFull (176.94s)
--- PASS: TestAccAWSGlueJob_GlueVersion (180.31s)
--- PASS: TestAccAWSGlueJob_Tags (182.02s)
--- PASS: TestAccAWSGlueJob_WorkerType (183.34s)
--- PASS: TestAccAWSGlueJob_PythonShell (184.92s)
--- PASS: TestAccAWSGlueMLTransform_disappears (42.07s)
--- PASS: TestAccAWSGlueMLTransform_maxRetries (111.80s)
--- PASS: TestAccAWSGlueMLTransform_timeout (101.81s)
--- PASS: TestAccAWSGlueMLTransform_tags (119.57s)
--- PASS: TestAccAWSGlueMLTransform_workerType (59.53s)
--- PASS: TestAccAWSGlueMLTransform_maxCapacity (57.47s)

@YakDriver YakDriver requested a review from a team October 20, 2020 15:42
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 20, 2020
@YakDriver YakDriver assigned anGie44 and unassigned gdavison Oct 27, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks greeat! 🎉

@YakDriver YakDriver added this to the v3.13.0 milestone Oct 27, 2020
@YakDriver YakDriver merged commit 8f38961 into master Oct 27, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-glue branch October 27, 2020 23:46
@YakDriver
Copy link
Member Author

YakDriver commented Oct 27, 2020

@anGie44 ➕ 💯 🎉 🎉

@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants