Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint to route table association can be read before Create is successful #16200

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12449.
Also add a _disappears test: #13826.

Release note for CHANGELOG:

resource/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint and route table association can be read before Create is successful

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_disappears
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (36.13s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (37.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.717s

@ewbankkit ewbankkit requested a review from a team as a code owner November 14, 2020 22:04
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2020
@ewbankkit ewbankkit changed the title r/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint and route table association can be read before Create is successful r/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint to route table association can be read before Create is successful Nov 14, 2020
…internal finder package.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (38.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.472s
…hicorp#13826).

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_disappears -timeout 120m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_disappears
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (40.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.670s
…and route table association can be read before Create is successful.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_disappears
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (36.13s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (37.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.717s
…ableAssociation' to 'VpcEndpointRouteTableAssociationExists'.

Acceptance test output:

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_disappears
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (35.05s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (38.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.164s
@ewbankkit ewbankkit force-pushed the b-aws_vpc_endpoint_route_table_association-wait-for-available branch from 3b8398d to 96f346d Compare January 4, 2021 14:21
Base automatically changed from master to main January 23, 2021 00:59
@ewbankkit
Copy link
Contributor Author

Closing this until we have a more general read-after-write solution.
Cam be reopened or the code reused once we're there.

@ewbankkit ewbankkit closed this Feb 17, 2021
@ewbankkit ewbankkit deleted the b-aws_vpc_endpoint_route_table_association-wait-for-available branch February 17, 2021 15:45
@ghost
Copy link

ghost commented Mar 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider produced inconsistent result after apply - aws_vpc_endpoint_route_table_association.s3_vpc_endpoint
1 participant