-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint to route table association can be read before Create is successful #16200
Closed
ewbankkit
wants to merge
5
commits into
hashicorp:main
from
ewbankkit:b-aws_vpc_endpoint_route_table_association-wait-for-available
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
Managed by automation to categorize the size of a PR.
service/ec2
Issues and PRs that pertain to the ec2 service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
labels
Nov 14, 2020
ewbankkit
changed the title
r/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint and route table association can be read before Create is successful
r/aws_vpc_endpoint_route_table_association: Ensure that VPC endpoint to route table association can be read before Create is successful
Nov 14, 2020
…outeTableAssociationCreateID'.
…internal finder package. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m === RUN TestAccAWSVpcEndpointRouteTableAssociation_basic === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic === CONT TestAccAWSVpcEndpointRouteTableAssociation_basic --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (38.42s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 38.472s
…hicorp#13826). Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_disappears -timeout 120m === RUN TestAccAWSVpcEndpointRouteTableAssociation_disappears === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears === CONT TestAccAWSVpcEndpointRouteTableAssociation_disappears --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (40.62s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 40.670s
…and route table association can be read before Create is successful. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m === RUN TestAccAWSVpcEndpointRouteTableAssociation_basic === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic === RUN TestAccAWSVpcEndpointRouteTableAssociation_disappears === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears === CONT TestAccAWSVpcEndpointRouteTableAssociation_basic === CONT TestAccAWSVpcEndpointRouteTableAssociation_disappears --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (36.13s) --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (37.66s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 37.717s
…ableAssociation' to 'VpcEndpointRouteTableAssociationExists'. Acceptance test output: make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 120m === RUN TestAccAWSVpcEndpointRouteTableAssociation_basic === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic === RUN TestAccAWSVpcEndpointRouteTableAssociation_disappears === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears === CONT TestAccAWSVpcEndpointRouteTableAssociation_basic === CONT TestAccAWSVpcEndpointRouteTableAssociation_disappears --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (35.05s) --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (38.10s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 38.164s
ewbankkit
force-pushed
the
b-aws_vpc_endpoint_route_table_association-wait-for-available
branch
from
January 4, 2021 14:21
3b8398d
to
96f346d
Compare
Closing this until we have a more general read-after-write solution. |
ewbankkit
deleted the
b-aws_vpc_endpoint_route_table_association-wait-for-available
branch
February 17, 2021 15:45
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
service/ec2
Issues and PRs that pertain to the ec2 service.
size/XL
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #12449.
Also add a
_disappears
test: #13826.Release note for CHANGELOG:
Output from acceptance testing: