-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(log_analytics_storage_insights): Parse subscriptionId from workspaceId #28469
fix(log_analytics_storage_insights): Parse subscriptionId from workspaceId #28469
Conversation
089bd4d
to
cc1dfac
Compare
…aceId Subscription ID where to create `log_analytics_storage_insights` should be the same as the Log Analytics Workspace. When passing a `workspaceId` with a different Azure subscription than the current one, resource group could not be found: Error: creating/updating Storage Insight Config (Subscription: "13-xxxx-aa" Resource Group Name: "rg-dev-test" Workspace Name: "logaws-dev-test" Storage Insight Config Name: "logsi-stdevstoragestoragsjkbl4"): unexpected status 404 (404 Not Found) with error: ResourceGroupNotFound: Resource group 'rg-dev-test' could not be found. Fixes hashicorp#28466
cc1dfac
to
1fb8607
Compare
1fb8607
to
4fb1ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xescab LGTM 👍
* Update for #27950 * Update for #27824 * Update for #28592 #28583 #28599 #28590 #28453 * Update #28528 * Update for #27853 * Update CHANGELOG.md #28221 * Update for #27760 * Update CHANGELOG.md #28480 * Update CHANGELOG.md typo * Update CHANGELOG.md #28372 * Update CHANGELOG.md for #26047 also alphabetised ENHANCEMENTS * Update for #28146 * Update CHANGELOG.md #28013 * Update CHANGELOG.md for #28492 * Update CHANGELOG.md for #28648 * Update CHANGELOG.md for #28549 * Update for #28469 #28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
…aceId (hashicorp#28469) Subscription ID where to create `log_analytics_storage_insights` should be the same as the Log Analytics Workspace. When passing a `workspaceId` with a different Azure subscription than the current one, resource group could not be found: Error: creating/updating Storage Insight Config (Subscription: "13-xxxx-aa" Resource Group Name: "rg-dev-test" Workspace Name: "logaws-dev-test" Storage Insight Config Name: "logsi-stdevstoragestoragsjkbl4"): unexpected status 404 (404 Not Found) with error: ResourceGroupNotFound: Resource group 'rg-dev-test' could not be found. Fixes hashicorp#28466
* Update for hashicorp#27950 * Update for hashicorp#27824 * Update for hashicorp#28592 hashicorp#28583 hashicorp#28599 hashicorp#28590 hashicorp#28453 * Update hashicorp#28528 * Update for hashicorp#27853 * Update CHANGELOG.md hashicorp#28221 * Update for hashicorp#27760 * Update CHANGELOG.md hashicorp#28480 * Update CHANGELOG.md typo * Update CHANGELOG.md hashicorp#28372 * Update CHANGELOG.md for hashicorp#26047 also alphabetised ENHANCEMENTS * Update for hashicorp#28146 * Update CHANGELOG.md hashicorp#28013 * Update CHANGELOG.md for hashicorp#28492 * Update CHANGELOG.md for hashicorp#28648 * Update CHANGELOG.md for hashicorp#28549 * Update for hashicorp#28469 hashicorp#28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Subscription ID where to create
log_analytics_storage_insights
should be the same as the Log Analytics Workspace.When passing a
workspaceId
with a different Azure subscription than the current one, resource group could not be found:Error: creating/updating Storage Insight Config (Subscription: "13-xxxx-aa"
Resource Group Name: "rg-dev-test"
Workspace Name: "logaws-dev-test"
Storage Insight Config Name: "logsi-stdevstoragestoragsjkbl4"): unexpected
status 404 (404 Not Found) with error: ResourceGroupNotFound:
Resource group 'rg-dev-test' could not be found.
Fixes #28466
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #28466
Note
If this PR changes meaningfully during the course of review please update the title and description as required.