-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing virtual_machine os disk response case-insensitively #28592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joshd-emergent LGTM 👍
* Update for #27950 * Update for #27824 * Update for #28592 #28583 #28599 #28590 #28453 * Update #28528 * Update for #27853 * Update CHANGELOG.md #28221 * Update for #27760 * Update CHANGELOG.md #28480 * Update CHANGELOG.md typo * Update CHANGELOG.md #28372 * Update CHANGELOG.md for #26047 also alphabetised ENHANCEMENTS * Update for #28146 * Update CHANGELOG.md #28013 * Update CHANGELOG.md for #28492 * Update CHANGELOG.md for #28648 * Update CHANGELOG.md for #28549 * Update for #28469 #28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
* Update for hashicorp#27950 * Update for hashicorp#27824 * Update for hashicorp#28592 hashicorp#28583 hashicorp#28599 hashicorp#28590 hashicorp#28453 * Update hashicorp#28528 * Update for hashicorp#27853 * Update CHANGELOG.md hashicorp#28221 * Update for hashicorp#27760 * Update CHANGELOG.md hashicorp#28480 * Update CHANGELOG.md typo * Update CHANGELOG.md hashicorp#28372 * Update CHANGELOG.md for hashicorp#26047 also alphabetised ENHANCEMENTS * Update for hashicorp#28146 * Update CHANGELOG.md hashicorp#28013 * Update CHANGELOG.md for hashicorp#28492 * Update CHANGELOG.md for hashicorp#28648 * Update CHANGELOG.md for hashicorp#28549 * Update for hashicorp#28469 hashicorp#28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Azure resource IDs aren’t strictly case-sensitive, they can fail to parse if the parser enforces exact casing. To ensure valid IDs aren’t rejected, parse them case-insensitively.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #28591
Note
If this PR changes meaningfully during the course of review please update the title and description as required.