Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_configuration - adding properties for data plane proxy configuration #28712

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Feb 6, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added data_plane_proxy_authentication_mode and data_plane_proxy_private_link_delegation_enabled to the azurerm_app_configuration data source and resource.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

2 test failures are unrelated and failing on main as well

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28422

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreallymatt sreallymatt merged commit 982b7c4 into main Feb 11, 2025
33 checks passed
@sreallymatt sreallymatt deleted the mp/app-config-dataplaneproxy branch February 11, 2025 14:59
@github-actions github-actions bot added this to the v4.19.0 milestone Feb 11, 2025
sreallymatt added a commit that referenced this pull request Feb 11, 2025
jackofallops added a commit that referenced this pull request Feb 14, 2025
* CHANGELOG.md for v4.19.0

* Update CHANGELOG.md #28523

* Update CHANGELOG.md #28691

* Updated to include #28717

* Update for #26680

* Update CHANGELOG.md #28633

* Update CHANGELOG.md for #28703

* Update CHANGELOG.md for #28391

* Update CHANGELOG.md #28725

* Update #28733

* Update CHANGELOG.md #28659

* Update for #28741

* Update CHANGELOG.md #28712

* Update CHANGELOG.md #28441

* Update CHANGELOG.md #28441

* Update CHANGELOG.md #28441

* Update CHANGELOG.md for #28602

* Update for #27424

* Update CHANGELOG.md for #28524

* Update CHANGELOG.md #28726

* Update for #28767

* Update for #28195

* prep for release v4.19.0

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
…configuration (hashicorp#28712)

* azurerm_app_configuration - add data plane proxy args

* minor fix

* same minor fix in data source
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
* CHANGELOG.md for v4.19.0

* Update CHANGELOG.md hashicorp#28523

* Update CHANGELOG.md hashicorp#28691

* Updated to include hashicorp#28717

* Update for hashicorp#26680

* Update CHANGELOG.md hashicorp#28633

* Update CHANGELOG.md for hashicorp#28703

* Update CHANGELOG.md for hashicorp#28391

* Update CHANGELOG.md hashicorp#28725

* Update hashicorp#28733

* Update CHANGELOG.md hashicorp#28659

* Update for hashicorp#28741

* Update CHANGELOG.md hashicorp#28712

* Update CHANGELOG.md hashicorp#28441

* Update CHANGELOG.md hashicorp#28441

* Update CHANGELOG.md hashicorp#28441

* Update CHANGELOG.md for hashicorp#28602

* Update for hashicorp#27424

* Update CHANGELOG.md for hashicorp#28524

* Update CHANGELOG.md hashicorp#28726

* Update for hashicorp#28767

* Update for hashicorp#28195

* prep for release v4.19.0

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_configuration - support for data_plane_proxy property
2 participants