[Enhancement:] azurerm_cdn_frontdoor_firewall_policy - js_challenge_cookie_expiration_in_minutes causing BadRequest error with Standard_AzureFrontDoor SKU

[WodansSon]

• azurerm_cdn_frontdoor_firewall_policy - added sku_name downgrade validation
• azurerm_cdn_frontdoor_profile - added sku_name downgrade validation

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

BUG FIXES:

• azurerm_cdn_frontdoor_firewall_policy - fixed an issue where the js_challenge_cookie_expiration_in_minutes policies default value was causing Standard_AzureFrontDoor skus to receive a BadRequest error [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related PR(s)

#28717
#28750

Related Issue(s)

Fixes #28716
Fixes #28713

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Thanks @WodansSon - Just a few items to take a look at, feel free to ping me in the off-line thread on these as needed as I know it's time sensitive (and I get so many GH notifications I'd not want to miss a reply 🙈)

[jackofallops]

Since this is now O+C, should we not always set it? (relating to the comment on the schema default above...)

[WodansSon]

I don't think so, because if the resource is a Standard sku the javascriptChallengeExpirationInMinutes field will be nil, it will only have a value if it is a Premium sku, so I think some sort of filtering logic needs to be applied here. I have updated the logic in the Read function to only write the value of the javascriptChallengeExpirationInMinutes field to the state file if the javascriptChallengeExpirationInMinutes field is not nil. That said, I could flip the logic to always write the value if the sku is not Standard or to always write the value if the sku is Premium, at the end of the day it's six of one half dozen of the other, it kind of all works out in the wash whichever way we go. I am open any of the above options...

Fixed.

[jackofallops]

Thanks for the changes @WodansSon - This LGTM now 👍
Tests are all green too: