Unnecessary check in resourceComputeInstanceRead

[maikzumstrull]

Terraform Version

0.9.8

Affected Resource(s)

google_compute_instance

Expected Behavior

Terraform should notice that different disks are attached to an instance than it expects. It should be possible to ignore this condition with lifecycle/ignore_changes.

Actual Behavior

Terraform errors out trying to refresh the instance.

As far as I can tell, this check: https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_compute_instance.go#L852-L854 is simply not necessary. In any case, the result should be a resource specification that TF can diff, not error on refresh.

[danawillow]

Hey @maikzumstrull, thanks for the report. I'm doing some large changes around the way we handle disks right now (see #122 and #123 for an idea of where we're headed) and that got check got caught up in the middle of them. I'm going to focus my efforts on the larger change rather than trying to fix this check specifically, but I appreciate the report!

[maikzumstrull]

The problematic code has moved around a bit, but it's still in there and still breaks operations really badly (because Terraform errors out instead of just reporting "this instance looks different than expected" and considering that in the plan). This also causes #355.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!