Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle ignore_changes = "disk" doesn't work on disks for Compute instances #355

Closed
beenanner opened this issue Aug 24, 2017 · 7 comments · Fixed by #600
Closed

Lifecycle ignore_changes = "disk" doesn't work on disks for Compute instances #355

beenanner opened this issue Aug 24, 2017 · 7 comments · Fixed by #600
Assignees
Labels

Comments

@beenanner
Copy link

Quick check if this is a known issue if not I can add the additional details to reproduce, but I'm unable to apply the ignore_changes to a compute instances that has additional disks attached via RexRay(https://github.com/codedellemc/rexray).

@beenanner
Copy link
Author

I've also tried adding all the new ones.

lifecycle {
      ignore_changes = ["boot_disk", "scratch_disk", "attached_disk", "disk"]
  }

@beenanner
Copy link
Author

Output shows expected 1 disk since it was booted with only the boot_disk. :-)


Error refreshing state: 1 error(s) occurred:

* google_compute_instance.worker: 1 error(s) occurred:

* google_compute_instance.worker[0]: google_compute_instance.worker.0: Expected 1 disks, API returned 9

@danawillow danawillow self-assigned this Aug 26, 2017
@danawillow
Copy link
Contributor

Everything about attached disks is currently in flux, but I'll look into seeing if I can remove that check.

@beenanner
Copy link
Author

beenanner commented Aug 26, 2017

Thanks @danawillow that would help out my use-case. Regardless awesome job on all the recent stuff, loving it! :-) Let me know if you need me to test anything.

@dkazhdan
Copy link

Sorry i am being confused, would that mean that ignore_changes =volume wont work for rexray attached volumes then? much appreciated

@beenanner
Copy link
Author

@dkazhdan I dont think it's specific to rexray its any externally attached disks not defined within terraform. Rexray was just my specific use case. :-)

@danawillow danawillow added the bug label Oct 3, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @cornmander
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants