Labels/annotations not being imported through terraform import

[mixedCase]

Running terraform import on a bunch of resources does not import metadata labels nor annotations to state.

Terraform Version

Terraform v0.12.18

• provider.aws v2.43.0
• provider.kubernetes v1.10.0

Affected Resource(s)

I just reproduced it with kubernetes_cluster_role, kubernetes_cluster_role_binding, kubernetes_config_map, kubernetes_deployment, kubernetes_namespace, kubernetes_role, kubernetes_role_binding, kubernetes_service and kubernetes_service_account. But I assume it affects all resources with labels in metadata.

Terraform Configuration Files

Partial example:

locals {
  ingress_name = "ingress-nginx"
  ingress_labels = {
    "app.kubernetes.io/name"    = "ingress-nginx"
    "app.kubernetes.io/part-of" = "ingress-nginx"
  }
}

resource "kubernetes_namespace" "ingress_nginx" {
  metadata {
    name   = local.ingress_name
    labels = local.ingress_labels
  }
}

Expected Behavior

Terraform import should've included label and annotation metadata in state.

Actual Behavior

It didn't. JSON screenshot comparing some of the state of one of the resources in the environment where I initially created it, and to the right, the one where I tried to terraform import it:

Steps to Reproduce

Instantiate the resource in one environment, try to import it in another one. Label metadata will be missing.

Important Factoids

Not really important, but just in case it's useful as a testing scenario or w/e: this was found during a refactor where an environment controlled resources that were to be shared with another environment. As a solution, a separate (shared) environment was created and the resources imported to it so that terraform_remote_state could be used in each user environment.

NOTE: This was edited to add annotations after the fact, as I just noticed a resource that missed its annotations as well.

[elkbullwinkle]

I bumped into the same thing, I believe that it's related to the original stand that kubernetes.io labels are ignored, however with a recent change if those have been explicitly defined in the terraform file, these should be respected during import as well, otherwise after importing the resource on the next run it tries to modify the resource with explicitly defined labels, even though they already exist, just missing from the state files.

[DrFaust92]

Maybe we can filter well known labels like as specified here: https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/ ?

similar to what is proposed here with tolerations #955 (comment)

I opened a PR for tolerations #978

[ixevix]

Running into this as well.

Terraform v0.12.29

• provider.aws v3.30.0
• provider.kubernetes v2.0.2

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.