Match specific tolerations to prevent Diffs

[DrFaust92]

Description

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

--- PASS: TestAccKubernetesDeployment_with_tolerations (54.41s)
--- PASS: TestAccKubernetesDeployment_with_tolerations_unset_toleration_seconds (11.52s)

--- PASS: TestAccKubernetesDaemonSet_with_tolerations (5.58s)
--- PASS: TestAccKubernetesDaemonSet_with_tolerations_unset_toleration_seconds (6.17s)

References

Closes #955

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[DrFaust92]

rebased

[dak1n1]

This looks good! I did some manual testing and ran the full set of acceptance tests on it, and everything passed. I just left one suggestion.

[dak1n1]

Instead of hard-coding these names, how would you feel about pulling the values from the Kubernetes API library? They're defined as constants here:

https://github.com/kubernetes/kubernetes/blob/ea0764452222146c47ec826977f49d7001b0ea8c/staging/src/k8s.io/api/core/v1/well_known_taints.go#L22

For example:

	v1.TaintNodeNotReady:           "",
	v1.TaintNodeUnreachable:        "",

Then any future naming changes will be pulled in automatically through that library. I also noticed that file contains one that was missing from the PR: TaintNodePIDPressure. (Probably because it wasn't listed on their docs page).

[DrFaust92]

Nice, will change

[DrFaust92]

done.

[dak1n1]

Thanks for this contribution!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!