Revert "Filter well known labels and annotations (#1253)"

[jrhouston]

Description

This PR reverts #1253 . We didn't capture all the possible internal annotations and labels, and it seems there's many more that are going to make maintaining this list a maintenance burden.

The original issue this was meant to solve was #722 so I have instead added app.kubernetes.io as an exception to the isInternalKey function for now. We have prioritized #746 which should make dealing with these labels and annotations less brittle.

@DrFaust92 just FYI.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

Revert "Filter well known labels and annotations (#1253)"

References

#1296

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[dak1n1]

Tests look good in AKS and GKE. Thanks for this fix!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.