Add tls_server_name provider options.
#1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @bartoszj, Thank you for your contribution. I have left one comment there. Could you please look at it? Thank you! |
Hello. Unfortunately I cannot see your comment :( Can you add it once again? |
arybolovlev
reviewed
Mar 16, 2022
jrhouston
requested changes
Mar 21, 2022
BBBmau
approved these changes
Jun 21, 2023
jrhouston
approved these changes
Jun 21, 2023
BBBmau
added a commit
that referenced
this pull request
Jun 22, 2023
* Add `tls_server_name` provider options. * Restore accidentally removed `client_certificate` parameter. * Fixed description * add changelog-entry --------- Co-authored-by: Mauricio Alvarez Leon <[email protected]> Co-authored-by: BBBmau <[email protected]>
BBBmau
added a commit
that referenced
this pull request
Jun 23, 2023
* add data source and tests * add docs * add changelog-entry * add copyright headers * make spec block optional * fix formatting in docs * update tests * add changelog-entry * remove sidebar current * Fix field_manager attribute name in node_taint docs (#2138) * bump actions/stale (#2142) * add `resource_kubernetes_endpointslice` (#2086) * initial resource creation * initial structures commit * add flatteners and expanders * initial create/read functions * update read function * add to provider.go * add finished schema with working tfplan * fix expand on SliceEndpoints * update to TypeList * update to using TypeList * update endpoints expander * fix flattener errors * add expander for objectref and flattener for conditions * add changelog-entry * initial tests * add missing port change check and use proper read function * get update working as well as adding ForceNew to address_type attribute * finish endpoint_slice_v1_test.go * add descriptions to attributes * add docs * website-lint-fix * add validator functions to port, hostname, and addresstype * add int check * fix test format * refactor validate functions * set to correct port * Add `tls_server_name` provider options. (#1638) * Add `tls_server_name` provider options. * Restore accidentally removed `client_certificate` parameter. * Fixed description * add changelog-entry --------- Co-authored-by: Mauricio Alvarez Leon <[email protected]> Co-authored-by: BBBmau <[email protected]> * Add GHA for running AKS (#2056) Co-authored-by: Alex Somesan <[email protected]> * Fix go version in AKS GHA (#2153) * add v1 * update docs --------- Co-authored-by: Stano Bocinec <[email protected]> Co-authored-by: Bartosz Janda <[email protected]> Co-authored-by: Sheneska Williams <[email protected]> Co-authored-by: Alex Somesan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
tls_server_name.Sometimes it is needed to connect to Kubernetes cluster using address which is not included in certificates SNIs. like IP addresses, SSH tunnels, etc.
insecureparameter can be used in such scenarios, but it disable certificate validation. By usingtls_server_nameit is still possible to validate server certificate.Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note